diff options
| author | Peter Lemenkov <lemenkov@gmail.com> | 2019-10-22 18:32:31 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-10-25 07:02:18 +0000 |
| commit | cfc93cbb660e2092374151dc616be0798854378e (patch) | |
| tree | 5085eef9d4442ede2a48364ed78d57f32268e6fd | |
| parent | b2832e3586530361cf92bdf55d060365fdcdf44c (diff) | |
| download | coreboot-cfc93cbb660e2092374151dc616be0798854378e.tar.xz | |
mb/lenovo/{t60,x201,x60}/smihandler: Remove SMM reinitialization
Remove SMM reinitialization since it's already done in src/ec/lenovo/h8.
Untested on a real hardware.
See also commit 8953d4a1 with Change-Id
I33fd829a7e34aefa8f76ca6020cc8e802f7aab17 ("mb/lenovo/*/smihandler: Get
rid of mainboard_io_trap_handler").
Change-Id: Icc582527db15f3a31cdee8948bc5a190240fdc84
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36235
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
| -rw-r--r-- | src/mainboard/lenovo/t60/smihandler.c | 14 | ||||
| -rw-r--r-- | src/mainboard/lenovo/x201/smihandler.c | 14 | ||||
| -rw-r--r-- | src/mainboard/lenovo/x60/smihandler.c | 14 |
3 files changed, 0 insertions, 42 deletions
diff --git a/src/mainboard/lenovo/t60/smihandler.c b/src/mainboard/lenovo/t60/smihandler.c index 51ced894be..3e97ed4a73 100644 --- a/src/mainboard/lenovo/t60/smihandler.c +++ b/src/mainboard/lenovo/t60/smihandler.c @@ -28,13 +28,6 @@ #define LVTMA_BL_MOD_LEVEL 0x7af9 /* ATI Radeon backlight level */ -static void mainboard_smm_init(void) -{ - printk(BIOS_DEBUG, "initializing SMI\n"); - /* Enable 0x1600/0x1600 register pair */ - ec_set_bit(0x00, 0x05); -} - static void mainboard_smi_brightness_down(void) { u8 *bar; @@ -59,13 +52,6 @@ static void mainboard_smi_brightness_up(void) int mainboard_io_trap_handler(int smif) { - static int smm_initialized; - - if (!smm_initialized) { - mainboard_smm_init(); - smm_initialized = 1; - } - switch (smif) { case SMI_DOCK_CONNECT: /* If there's an legacy I/O module present, we're not diff --git a/src/mainboard/lenovo/x201/smihandler.c b/src/mainboard/lenovo/x201/smihandler.c index e80782acf6..c9c52abc1d 100644 --- a/src/mainboard/lenovo/x201/smihandler.c +++ b/src/mainboard/lenovo/x201/smihandler.c @@ -29,22 +29,8 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13 -static void mainboard_smm_init(void) -{ - printk(BIOS_DEBUG, "initializing SMI\n"); - /* Enable 0x1600/0x1600 register pair */ - ec_set_bit(0x00, 0x05); -} - int mainboard_io_trap_handler(int smif) { - static int smm_initialized; - - if (!smm_initialized) { - mainboard_smm_init(); - smm_initialized = 1; - } - switch (smif) { case SMI_DOCK_CONNECT: ec_clr_bit(0x03, 2); diff --git a/src/mainboard/lenovo/x60/smihandler.c b/src/mainboard/lenovo/x60/smihandler.c index 18e5046289..0a2c7e2e6b 100644 --- a/src/mainboard/lenovo/x60/smihandler.c +++ b/src/mainboard/lenovo/x60/smihandler.c @@ -29,13 +29,6 @@ #define GPE_EC_SCI 12 -static void mainboard_smm_init(void) -{ - printk(BIOS_DEBUG, "initializing SMI\n"); - /* Enable 0x1600/0x1600 register pair */ - ec_set_bit(0x00, 0x05); -} - static void mainboard_smi_save_cmos(void) { u8 val; @@ -55,13 +48,6 @@ static void mainboard_smi_save_cmos(void) int mainboard_io_trap_handler(int smif) { - static int smm_initialized; - - if (!smm_initialized) { - mainboard_smm_init(); - smm_initialized = 1; - } - switch (smif) { case SMI_DOCK_CONNECT: ec_clr_bit(0x03, 2); |