summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2019-05-28 09:47:38 +0200
committerNico Huber <nico.h@gmx.de>2019-06-03 10:14:06 +0000
commitd44d4f0f4eca026f81a3b2a21518d7524235f144 (patch)
tree6f8ec60a345401731ad18f8372174af0e1a7e1bb
parent60a0a3d629d91f8909e5209753baf8f4b6bcc1f5 (diff)
downloadcoreboot-d44d4f0f4eca026f81a3b2a21518d7524235f144.tar.xz
mb/lenovo/*: Remove useless smihandler code
This code to handle the brightness from SMM is copied from the Lenovo Thinkpad X60 code, but does not work on later generation. The PCI device it tries to address does not even exist on those devices. Change-Id: Ia959eb5b747846048396e66d4c926c96c27f3878 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33138 Reviewed-by: Patrick Rudolph <siro@das-labor.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/lenovo/t420s/smihandler.c30
-rw-r--r--src/mainboard/lenovo/t430s/smihandler.c30
-rw-r--r--src/mainboard/lenovo/t520/smihandler.c30
-rw-r--r--src/mainboard/lenovo/t530/smihandler.c30
-rw-r--r--src/mainboard/lenovo/x220/smihandler.c30
5 files changed, 0 insertions, 150 deletions
diff --git a/src/mainboard/lenovo/t420s/smihandler.c b/src/mainboard/lenovo/t420s/smihandler.c
index be4228dc90..2713725b36 100644
--- a/src/mainboard/lenovo/t420s/smihandler.c
+++ b/src/mainboard/lenovo/t420s/smihandler.c
@@ -27,23 +27,6 @@
#define GPE_EC_SCI 1
#define GPE_EC_WAKE 13
-static void mainboard_smi_brightness_up(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
-}
-
-static void mainboard_smi_brightness_down(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
- (value - 0x10) & 0xf0);
-}
-
static void mainboard_smi_handle_ec_sci(void)
{
u8 status = inb(EC_SC);
@@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event);
-
- switch (event) {
- case 0x14:
- /* brightness up */
- mainboard_smi_brightness_up();
- break;
- case 0x15:
- /* brightness down */
- mainboard_smi_brightness_down();
- break;
- default:
- break;
- }
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t430s/smihandler.c b/src/mainboard/lenovo/t430s/smihandler.c
index 876d81c0d7..2810e5ae91 100644
--- a/src/mainboard/lenovo/t430s/smihandler.c
+++ b/src/mainboard/lenovo/t430s/smihandler.c
@@ -27,23 +27,6 @@
#define GPE_EC_SCI 1
#define GPE_EC_WAKE 13
-static void mainboard_smi_brightness_up(void)
-{
- u8 value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4);
-
- if (value < 0xf0)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
-}
-
-static void mainboard_smi_brightness_down(void)
-{
- u8 value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4);
-
- if (value > 0x10)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
- (value - 0x10) & 0xf0);
-}
-
static void mainboard_smi_handle_ec_sci(void)
{
u8 status = inb(EC_SC);
@@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event);
-
- switch (event) {
- case 0x14:
- /* brightness up */
- mainboard_smi_brightness_up();
- break;
- case 0x15:
- /* brightness down */
- mainboard_smi_brightness_down();
- break;
- default:
- break;
- }
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t520/smihandler.c b/src/mainboard/lenovo/t520/smihandler.c
index 88ce5046fc..46ad664c3c 100644
--- a/src/mainboard/lenovo/t520/smihandler.c
+++ b/src/mainboard/lenovo/t520/smihandler.c
@@ -27,23 +27,6 @@
#define GPE_EC_SCI 1
#define GPE_EC_WAKE 13
-static void mainboard_smi_brightness_up(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
-}
-
-static void mainboard_smi_brightness_down(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
- (value - 0x10) & 0xf0);
-}
-
static void mainboard_smi_handle_ec_sci(void)
{
u8 status = inb(EC_SC);
@@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event);
-
- switch (event) {
- case 0x14:
- /* brightness up */
- mainboard_smi_brightness_up();
- break;
- case 0x15:
- /* brightness down */
- mainboard_smi_brightness_down();
- break;
- default:
- break;
- }
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/t530/smihandler.c b/src/mainboard/lenovo/t530/smihandler.c
index bf0f81fc57..46ad664c3c 100644
--- a/src/mainboard/lenovo/t530/smihandler.c
+++ b/src/mainboard/lenovo/t530/smihandler.c
@@ -27,23 +27,6 @@
#define GPE_EC_SCI 1
#define GPE_EC_WAKE 13
-static void mainboard_smi_brightness_up(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
-}
-
-static void mainboard_smi_brightness_down(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
- (value - 0x10) & 0xf0);
-}
-
static void mainboard_smi_handle_ec_sci(void)
{
u8 status = inb(EC_SC);
@@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event);
-
- switch (event) {
- case 0x14:
- /* brightness up */
- mainboard_smi_brightness_up();
- break;
- case 0x15:
- /* brightness down */
- mainboard_smi_brightness_down();
- break;
- default:
- break;
- }
}
void mainboard_smi_gpi(u32 gpi_sts)
diff --git a/src/mainboard/lenovo/x220/smihandler.c b/src/mainboard/lenovo/x220/smihandler.c
index bf0f81fc57..46ad664c3c 100644
--- a/src/mainboard/lenovo/x220/smihandler.c
+++ b/src/mainboard/lenovo/x220/smihandler.c
@@ -27,23 +27,6 @@
#define GPE_EC_SCI 1
#define GPE_EC_WAKE 13
-static void mainboard_smi_brightness_up(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
-}
-
-static void mainboard_smi_brightness_down(void)
-{
- u8 value;
-
- if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
- pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
- (value - 0x10) & 0xf0);
-}
-
static void mainboard_smi_handle_ec_sci(void)
{
u8 status = inb(EC_SC);
@@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event);
-
- switch (event) {
- case 0x14:
- /* brightness up */
- mainboard_smi_brightness_up();
- break;
- case 0x15:
- /* brightness down */
- mainboard_smi_brightness_down();
- break;
- default:
- break;
- }
}
void mainboard_smi_gpi(u32 gpi_sts)