summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoe Moore <awokd@danwin1210.me>2019-10-23 05:16:56 -0600
committerNico Huber <nico.h@gmx.de>2020-01-10 15:10:36 +0000
commit0560a66450a600d8038933210dd3406cbb298131 (patch)
treec0392ac80a6f11126f9bd3896330ab11b04bf921
parentefa022db501de6d8dcd4a76e74d0f23a1ffd9412 (diff)
downloadcoreboot-0560a66450a600d8038933210dd3406cbb298131.tar.xz
vc/amd/agesa: Remove unused assignments
'Status' is assigned a value three times before it is checked. Remove the first two assignments. Change-Id: Id7136d62b4dbd6dce877983467960373b3a7ac22 Signed-off-by: Joe Moore <awokd@danwin1210.me> Found-by: Coverity CID 1241809 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36257 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Frans Hendriks <fhendriks@eltan.com> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
-rw-r--r--src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c2
-rw-r--r--src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c2
-rw-r--r--src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c2
3 files changed, 0 insertions, 6 deletions
diff --git a/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c b/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
index 70aa595944..440c5ff68c 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
@@ -474,13 +474,11 @@ GfxIntegratedEnumConnectorsForDevice (
if (ExtDisplayDeviceInfo == NULL) {
//Run out of supported display device types
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
- Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
if ((Gfx->Gnb3dStereoPinIndex != 0) && (ConnectorEnumInfo.Engine->Type.Ddi.DdiData.HdpIndex == (Gfx->Gnb3dStereoPinIndex - 1))) {
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
- Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
index f3af5e9b17..2d42063340 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
@@ -488,13 +488,11 @@ GfxIntegratedEnumConnectorsForDevice (
if (ExtDisplayDeviceInfo == NULL) {
//Run out of supported display device types
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
- Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
if ((Gfx->Gnb3dStereoPinIndex != 0) && (ConnectorEnumInfo.Engine->Type.Ddi.DdiData.HdpIndex == (Gfx->Gnb3dStereoPinIndex - 1))) {
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
- Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
index c9c9166610..23501227eb 100644
--- a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
+++ b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbGfxInitLibV1/GfxEnumConnectors.c
@@ -488,13 +488,11 @@ GfxIntegratedEnumConnectorsForDevice (
if (ExtDisplayDeviceInfo == NULL) {
//Run out of supported display device types
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
- Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}
if ((Gfx->Gnb3dStereoPinIndex != 0) && (ConnectorEnumInfo.Engine->Type.Ddi.DdiData.HdpIndex == (Gfx->Gnb3dStereoPinIndex - 1))) {
AGESA_STATUS_UPDATE (AGESA_ERROR, ConnectorEnumInfo.Status);
- Status = AGESA_ERROR;
PcieConfigDisableEngine (ConnectorEnumInfo.Engine);
}