diff options
| author | Sven Schnelle <svens@stackframe.org> | 2011-06-12 16:55:56 +0200 |
|---|---|---|
| committer | Sven Schnelle <svens@stackframe.org> | 2011-06-12 17:28:10 +0200 |
| commit | 0f9cd435145f1d34a6ebe67ad547c79bc4246f3d (patch) | |
| tree | e0dfe3856cd3d69c4fe7d62014ea73963a3d50f2 | |
| parent | 5d9a83c9f00a22896029b994cce65fa64aea827d (diff) | |
| download | coreboot-0f9cd435145f1d34a6ebe67ad547c79bc4246f3d.tar.xz | |
X60/T60: fix return value of mainboard_io_trap_handler()
The handler should return 1 if it handled the request. The current
code returns 0, which causes 'Unknown function' logs.
Change-Id: Ic296819a5f8c6f1f97b7d47148182226684882a0
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/29
Tested-by: build bot (Jenkins)
| -rw-r--r-- | src/mainboard/lenovo/t60/mainboard_smi.c | 8 | ||||
| -rw-r--r-- | src/mainboard/lenovo/x60/mainboard_smi.c | 8 |
2 files changed, 8 insertions, 8 deletions
diff --git a/src/mainboard/lenovo/t60/mainboard_smi.c b/src/mainboard/lenovo/t60/mainboard_smi.c index 5e0f6a98b0..30c2420f9c 100644 --- a/src/mainboard/lenovo/t60/mainboard_smi.c +++ b/src/mainboard/lenovo/t60/mainboard_smi.c @@ -68,11 +68,11 @@ int mainboard_io_trap_handler(int smif) break; default: - return 1; + return 0; } - /* On success, the IO Trap Handler returns 0 - * On failure, the IO Trap Handler returns a value != 0 */ - return 0; + /* On success, the IO Trap Handler returns 1 + * On failure, the IO Trap Handler returns a value != 1 */ + return 1; } diff --git a/src/mainboard/lenovo/x60/mainboard_smi.c b/src/mainboard/lenovo/x60/mainboard_smi.c index 78f7f2a4f6..d13055ee70 100644 --- a/src/mainboard/lenovo/x60/mainboard_smi.c +++ b/src/mainboard/lenovo/x60/mainboard_smi.c @@ -68,10 +68,10 @@ int mainboard_io_trap_handler(int smif) break; default: - return 1; + return 0; } - /* On success, the IO Trap Handler returns 0 - * On failure, the IO Trap Handler returns a value != 0 */ - return 0; + /* On success, the IO Trap Handler returns 1 + * On failure, the IO Trap Handler returns a value != 1 */ + return 1; } |