summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Zhao <john.zhao@intel.com>2019-07-09 14:27:28 -0700
committerMartin Roth <martinroth@google.com>2019-07-11 15:00:13 +0000
commit1ceac4efcfa3a9ccc0d44f77855f4949f59305b5 (patch)
tree946954147db100c61463e1642ff6d3814cf078ca
parentb8501c7c5f00a664ff644324af363d43c5af1bc2 (diff)
downloadcoreboot-1ceac4efcfa3a9ccc0d44f77855f4949f59305b5.tar.xz
soc/intel/common: Check bios_size and window_size after MIN operation
Clang Static Analyzer version 8.0.0 detects that the result of log2_ceil(bios_size) and log2_ceil(window_size) is undefined if the value of bios_size and window_size are negative. Add negative value Check for bios_size and window_size after MIN operation. Change-Id: I28577b6e0ba0ab45bb7804c17ba1f26c4b078b15 Signed-off-by: John Zhao <john.zhao@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34182 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--src/soc/intel/common/block/fast_spi/fast_spi.c2
-rw-r--r--src/soc/intel/common/block/lpc/lpc_lib.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/common/block/fast_spi/fast_spi.c b/src/soc/intel/common/block/fast_spi/fast_spi.c
index e40b84493e..5c29addcc9 100644
--- a/src/soc/intel/common/block/fast_spi/fast_spi.c
+++ b/src/soc/intel/common/block/fast_spi/fast_spi.c
@@ -241,7 +241,7 @@ void fast_spi_cache_bios_region(void)
* protection, so limit the cached bios region to be no more than 16MB.
* */
bios_size = MIN(bios_size, 16 * MiB);
- if (!bios_size)
+ if (bios_size <= 0)
return;
/* Round to power of two */
diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c
index b31c799a6a..975e4300bf 100644
--- a/src/soc/intel/common/block/lpc/lpc_lib.c
+++ b/src/soc/intel/common/block/lpc/lpc_lib.c
@@ -80,7 +80,7 @@ void lpc_open_pmio_window(uint16_t base, uint16_t size)
/* Each IO range register can only open a 256-byte window. */
window_size = MIN(size, LPC_LGIR_MAX_WINDOW_SIZE);
- if (!window_size)
+ if (window_size <= 0)
return;
/* Window size must be a power of two for the AMASK to work. */