diff options
| author | Paul Menzel <pmenzel@molgen.mpg.de> | 2017-09-27 15:06:57 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2017-10-14 11:28:14 +0000 |
| commit | 38a906b0e1994ca71179dcc1a0cfb48566e7c6ed (patch) | |
| tree | a023eb7c40543599da41cdad1707241a07667510 | |
| parent | fe5030ecebc282b1f6d3811aa111d991b72ce213 (diff) | |
| download | coreboot-38a906b0e1994ca71179dcc1a0cfb48566e7c6ed.tar.xz | |
util: Make TZ environment variable POSIX compatible
`TZ='UTC'` is not a portable setting for the TZ environment variable.
POSIX says you’re supposed to use something like `TZ='UTC0'` instead.
Although `TZ='UTC'` works when GLIBC is used, this is not necessarily
true on other POSIX platforms. [1][2]
[1] http://lists.alioth.debian.org/pipermail/reproducible-builds/Week-of-Mon-20170918/009289.html
[2] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
Change-Id: I1dca0b84de0ec0af3a103e2cbbf731512eb59497
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/21721
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Martin Roth <martinroth@google.com>
| -rwxr-xr-x | util/board_status/to-wiki/towiki.sh | 2 | ||||
| -rwxr-xr-x | util/genbuild_h/genbuild_h.sh | 4 | ||||
| -rwxr-xr-x | util/release/build-release | 2 | ||||
| -rwxr-xr-x | util/scripts/update_submodules | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/util/board_status/to-wiki/towiki.sh b/util/board_status/to-wiki/towiki.sh index 769ae5f6cd..cf25cc2ff3 100755 --- a/util/board_status/to-wiki/towiki.sh +++ b/util/board_status/to-wiki/towiki.sh @@ -19,7 +19,7 @@ while read line; do commit=`echo $i | cut -d/ -f3` datetime_path=`echo $i | cut -d/ -f4` datetime=`echo $datetime_path | tr _ :` - datetime_human=`LC_ALL=C TZ=UTC date --date="$datetime"` + datetime_human=`LC_ALL=C TZ=UTC0 date --date="$datetime"` upstream=`grep "^Upstream revision:" $vendor_board/$commit/$datetime_path/revision.txt |cut -d: -f2-` upstream=`git log -1 --format=%H $upstream` if ! echo "$have"| grep "^$vendor_board:" > /dev/null; then diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh index 044d901195..3575ad4c35 100755 --- a/util/genbuild_h/genbuild_h.sh +++ b/util/genbuild_h/genbuild_h.sh @@ -20,7 +20,7 @@ TIMESOURCE="" export LANG=C export LC_ALL=C -export TZ=UTC +export TZ=UTC0 top=`dirname $0`/../.. @@ -35,7 +35,7 @@ elif [ -e "${top}/.git" -a -x "$(command -v git)" ]; then else GITREV=Unknown TIMESOURCE="date" - DATE=$(LANG= LC_ALL=C TZ=UTC date +%s) + DATE=$(LANG= LC_ALL=C TZ=UTC0 date +%s) fi our_date() { diff --git a/util/release/build-release b/util/release/build-release index 089984b595..a3cec3eb8c 100755 --- a/util/release/build-release +++ b/util/release/build-release @@ -13,7 +13,7 @@ set -e # set local + tz to be reproducible LC_ALL=C LANG=C -TZ=UTC +TZ=UTC0 export LC_ALL LANG TZ if [ -z "$VERSION_NAME" ] || [ "$VERSION_NAME" = "--help" ] || [ -z "$COMMIT_ID" ]; then diff --git a/util/scripts/update_submodules b/util/scripts/update_submodules index fbf9d4f5b1..b555495eda 100755 --- a/util/scripts/update_submodules +++ b/util/scripts/update_submodules @@ -21,7 +21,7 @@ export LANG=C export LC_ALL=C -export TZ=UTC +export TZ=UTC0 min_commits=10 |