summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKrystian Hebel <krystian.hebel@3mdeb.com>2018-12-28 15:41:58 +0100
committerPatrick Georgi <pgeorgi@google.com>2019-01-09 09:59:58 +0000
commit3f88d7fd29018e1ed92f70a4354850be37937d55 (patch)
treee71f7b87a9abcad2f0fc1231b4ce8cff7079c5bd
parent6fffd70435084fb1d3237fcb1a11f11849721e8f (diff)
downloadcoreboot-3f88d7fd29018e1ed92f70a4354850be37937d55.tar.xz
agesawrapper.c: check if HOP_COUNT_TABLE exists before AmdInitLate()
If HOP_COUNT_TABLE doesn't exist AmdInitLate() returns error when creating CDIT, which scaries users. This patch turns off CDIT generation. After this patch AGESA_UNSUPPORTED is returned due to a bug in AGESA which cannot be walked around without disabling DMI table generation (`AGESA_STATUS Status = TRUE`, present in open source version of AGESA too). Change-Id: I868aa840ad3495a66a9d70b7803af237e7d5f049 Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com> Reviewed-on: https://review.coreboot.org/c/30475 Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/northbridge/amd/pi/agesawrapper.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/northbridge/amd/pi/agesawrapper.c b/src/northbridge/amd/pi/agesawrapper.c
index 3021b81358..b05c12012e 100644
--- a/src/northbridge/amd/pi/agesawrapper.c
+++ b/src/northbridge/amd/pi/agesawrapper.c
@@ -274,6 +274,11 @@ AGESA_STATUS agesawrapper_amdinitlate(void)
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
AmdLateParams->GnbLateConfiguration.GnbIoapicId = CONFIG_MAX_CPUS + 1;
AmdLateParams->GnbLateConfiguration.FchIoapicId = CONFIG_MAX_CPUS;
+ /* Code for creating CDIT requires hop count table. If it is not
+ * present AGESA_ERROR is returned, which confuses users. CDIT is not
+ * written to the ACPI tables anyway. */
+ AmdLateParams->PlatformConfig.UserOptionCdit = 0;
+
Status = AmdInitLate(AmdLateParams);
if (Status != AGESA_SUCCESS) {
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);