diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2017-05-16 21:50:27 -0500 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2017-05-18 15:42:39 +0200 |
| commit | 57e15e609e090ac7ec02b570d653b64cf12e4f88 (patch) | |
| tree | b31a062146d173f8350d6e3f01535fb07443b734 | |
| parent | bdb5c8feaed4cf914b474deeb30686e327ee9228 (diff) | |
| download | coreboot-57e15e609e090ac7ec02b570d653b64cf12e4f88.tar.xz | |
vbe: remove the necessity for a global vbe_mode_info_valid()
There's no users of vbe_mode_info_valid() aside from the local
compilation units. Remove the declaration and make the function
static to the current global implementers.
Change-Id: I4872ac6ad15ba6a86bba69d51a8348b9921c152d
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/19730
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
| -rw-r--r-- | src/device/oprom/realmode/x86.c | 2 | ||||
| -rw-r--r-- | src/device/oprom/yabel/vbe.c | 2 | ||||
| -rw-r--r-- | src/drivers/xgi/common/xgi_coreboot.c | 2 | ||||
| -rw-r--r-- | src/include/vbe.h | 1 |
4 files changed, 3 insertions, 4 deletions
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index 0534d42db8..69ac1fe23d 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -216,7 +216,7 @@ static void setup_realmode_idt(void) vbe_mode_info_t mode_info; static int mode_info_valid; -int vbe_mode_info_valid(void) +static int vbe_mode_info_valid(void) { return mode_info_valid; } diff --git a/src/device/oprom/yabel/vbe.c b/src/device/oprom/yabel/vbe.c index 913386458b..ec999012d2 100644 --- a/src/device/oprom/yabel/vbe.c +++ b/src/device/oprom/yabel/vbe.c @@ -156,7 +156,7 @@ vbe_info(vbe_info_t * info) static int mode_info_valid; -int vbe_mode_info_valid(void) +static int vbe_mode_info_valid(void) { return mode_info_valid; } diff --git a/src/drivers/xgi/common/xgi_coreboot.c b/src/drivers/xgi/common/xgi_coreboot.c index 4db06f9b6d..f7d81c86de 100644 --- a/src/drivers/xgi/common/xgi_coreboot.c +++ b/src/drivers/xgi/common/xgi_coreboot.c @@ -421,7 +421,7 @@ int xgifb_modeset(struct pci_dev *pdev, struct xgifb_video_info *xgifb_info) return 0; } -int vbe_mode_info_valid(void) +static int vbe_mode_info_valid(void) { return xgi_vbe_valid; } diff --git a/src/include/vbe.h b/src/include/vbe.h index 70c412490b..12fac77357 100644 --- a/src/include/vbe.h +++ b/src/include/vbe.h @@ -111,7 +111,6 @@ typedef struct { #define VESA_GET_MODE_INFO 0x4f01 #define VESA_SET_MODE 0x4f02 -int vbe_mode_info_valid(void); void vbe_set_graphics(void); void vbe_textmode_console(void); |