summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhuohao Lee <zhuohao@chromium.org>2018-03-30 10:18:04 +0800
committerAaron Durbin <adurbin@chromium.org>2018-04-01 19:50:30 +0000
commit7824d9bf699e245ff5c21262ff51acaeac0186af (patch)
tree5be4976a0135f0e9934f44cc5e7d24016b91b686
parentb1fc13ac9af0a74fc206991775933c19379058ba (diff)
downloadcoreboot-7824d9bf699e245ff5c21262ff51acaeac0186af.tar.xz
chromeec: fix an uninitialized local variable
google_chromeec_command() may only write the 1 or 2 bytes to variable r (4 bytes). However, this api returns 4 bytes data. To avaid returning the incorrect data, we need to initialize the local variable. BUG=b:76442548 BRANCH=none TEST=write 2 bytes data into the flash, then, read by cbi_get_uint32 Change-Id: I3395c97ab6bfd7882d7728310de8a29041190e76 Signed-off-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-on: https://review.coreboot.org/25460 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/ec/google/chromeec/ec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index efe22e2ab9..fb3ffab181 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -563,7 +563,7 @@ static int cbi_get_uint32(uint32_t *id, uint32_t type)
{
struct chromeec_command cmd;
struct ec_params_get_cbi p;
- uint32_t r;
+ uint32_t r = 0;
int rv;
p.type = type;