summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2019-07-14 09:16:58 +0200
committerPatrick Georgi <pgeorgi@google.com>2019-07-18 13:47:43 +0000
commit8881d575313281ef1d582054701811ff50f6ceae (patch)
treef796484d05d55b803d79836b58f750b7fc77176f
parent2c7d1848856ce7bd8539ed4af460a476c39ff2fb (diff)
downloadcoreboot-8881d575313281ef1d582054701811ff50f6ceae.tar.xz
nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT
Here, vga_disable stored but we read it only if MAINBOARD_DO_NATIVE_VGA_INIT. Found-by: scan-build 7.0.1-8 Change-Id: I5c359df71568b56f48eca9615c6265da33d4a073 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34331 Reviewed-by: Patrick Rudolph <siro@das-labor.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/northbridge/intel/i945/gma.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 54ff47cc64..d08b77d3e2 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -703,9 +703,8 @@ static void gma_func0_init(struct device *dev)
pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER
| PCI_COMMAND_IO | PCI_COMMAND_MEMORY);
- int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1;
-
if (CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT)) {
+ int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1;
if (acpi_is_wakeup_s3()) {
printk(BIOS_INFO,
"Skipping native VGA initialization when resuming from ACPI S3.\n");