summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2019-05-29 23:18:26 +0200
committerPatrick Georgi <pgeorgi@google.com>2019-06-03 13:23:55 +0000
commit8bbad6c8186037e67da9f1465078b5952c0c0899 (patch)
tree42900c6379e218dd2cbfc39bb3a6fe181f6a9501
parent51dc5ea735cd175a6d38d59d8b3b3eadee027e6c (diff)
downloadcoreboot-8bbad6c8186037e67da9f1465078b5952c0c0899.tar.xz
soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode()
The only path that leads here is guarded by both !DRIVERS_UART_ 8250MEM_32 and INTEL_LPSS_UART_FOR_CONSOLE but the latter selects the former. Change-Id: I6e0765b028572950991c45b45b2051f4f176a94a Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33095 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Lance Zhao <lance.zhao@gmail.com>
-rw-r--r--src/soc/intel/common/block/include/intelblocks/uart.h6
-rw-r--r--src/soc/intel/common/block/uart/uart.c4
2 files changed, 0 insertions, 10 deletions
diff --git a/src/soc/intel/common/block/include/intelblocks/uart.h b/src/soc/intel/common/block/include/intelblocks/uart.h
index ad2ddf4b28..55f259db7c 100644
--- a/src/soc/intel/common/block/include/intelblocks/uart.h
+++ b/src/soc/intel/common/block/include/intelblocks/uart.h
@@ -91,10 +91,4 @@ struct device *uart_get_device(void);
*/
struct device *soc_uart_console_to_device(int uart_console);
-/*
- * Set UART to legacy mode
- * Put UART in byte access mode for 16550 compatibility
- */
-void soc_uart_set_legacy_mode(void);
-
#endif /* SOC_INTEL_COMMON_BLOCK_UART_H */
diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index a8e5792a86..35c2c6cafb 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -139,10 +139,6 @@ void uart_bootblock_init(void)
uart_common_init(uart_get_device(),
UART_BASE(CONFIG_UART_FOR_CONSOLE));
- if (!CONFIG(DRIVERS_UART_8250MEM_32))
- /* Put UART in byte access mode for 16550 compatibility */
- soc_uart_set_legacy_mode();
-
/* Configure the 2 pads per UART. */
uart_configure_gpio_pads();
}