diff options
| author | Nico Huber <nico.huber@secunet.com> | 2012-06-14 16:03:01 +0200 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2012-06-21 08:05:31 +0200 |
| commit | 904a0ec9d0ae4f4af8bcb13363d6766a6feace6a (patch) | |
| tree | 29d1111d16cc0db1d0623816741b203fc45f88de | |
| parent | 14546853274bb21a760230ef5570d03bcb43430f (diff) | |
| download | coreboot-904a0ec9d0ae4f4af8bcb13363d6766a6feace6a.tar.xz | |
Don't use 64-bit constant 0x100000000 in linker scripts
The constant value 0x100000000 is used in linker scripts to calculate
offsets from the end of 32-bit-addressed memory. There is nothing
wrong with it, but 32-bit versions of ld do the calculation wrong.
Change-Id: I4e27c6fd0c864b4d98f686588bf78c7aa48bcba8
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: http://review.coreboot.org/1129
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
| -rw-r--r-- | src/arch/x86/lib/id.lds | 2 | ||||
| -rw-r--r-- | src/northbridge/via/vx800/romstrap.lds | 2 | ||||
| -rw-r--r-- | src/southbridge/nvidia/ck804/romstrap.lds | 2 | ||||
| -rw-r--r-- | src/southbridge/nvidia/mcp55/romstrap.lds | 2 | ||||
| -rw-r--r-- | src/southbridge/sis/sis966/romstrap.lds | 2 | ||||
| -rw-r--r-- | src/southbridge/via/k8t890/romstrap.lds | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/src/arch/x86/lib/id.lds b/src/arch/x86/lib/id.lds index 9e31ee615c..cfd091dc17 100644 --- a/src/arch/x86/lib/id.lds +++ b/src/arch/x86/lib/id.lds @@ -1,5 +1,5 @@ SECTIONS { - . = (0x100000000 - CONFIG_ID_SECTION_OFFSET) - (__id_end - __id_start); + . = (0xffffffff - CONFIG_ID_SECTION_OFFSET) - (__id_end - __id_start) + 1; .id (.): { *(.id) } diff --git a/src/northbridge/via/vx800/romstrap.lds b/src/northbridge/via/vx800/romstrap.lds index 4326b280a9..cd2b546818 100644 --- a/src/northbridge/via/vx800/romstrap.lds +++ b/src/northbridge/via/vx800/romstrap.lds @@ -19,7 +19,7 @@ */ SECTIONS { - . = (0x100000000 - 0x2c) - (__romstrap_end - __romstrap_start); + . = (0xffffffff - 0x2c) - (__romstrap_end - __romstrap_start) + 1; .romstrap (.): { *(.romstrap) } diff --git a/src/southbridge/nvidia/ck804/romstrap.lds b/src/southbridge/nvidia/ck804/romstrap.lds index c2ad368f01..3b8f497a05 100644 --- a/src/southbridge/nvidia/ck804/romstrap.lds +++ b/src/southbridge/nvidia/ck804/romstrap.lds @@ -19,7 +19,7 @@ */ SECTIONS { - . = (0x100000000 - 0x10) - (__romstrap_end - __romstrap_start); + . = (0xffffffff - 0x10) - (__romstrap_end - __romstrap_start) + 1; .romstrap (.): { *(.romstrap) } diff --git a/src/southbridge/nvidia/mcp55/romstrap.lds b/src/southbridge/nvidia/mcp55/romstrap.lds index c08aa32ca7..4dad42212d 100644 --- a/src/southbridge/nvidia/mcp55/romstrap.lds +++ b/src/southbridge/nvidia/mcp55/romstrap.lds @@ -20,7 +20,7 @@ */ SECTIONS { - . = (0x100000000 - 0x10) - (__romstrap_end - __romstrap_start); + . = (0xffffffff - 0x10) - (__romstrap_end - __romstrap_start) + 1; .romstrap (.): { *(.romstrap) } diff --git a/src/southbridge/sis/sis966/romstrap.lds b/src/southbridge/sis/sis966/romstrap.lds index c08aa32ca7..4dad42212d 100644 --- a/src/southbridge/sis/sis966/romstrap.lds +++ b/src/southbridge/sis/sis966/romstrap.lds @@ -20,7 +20,7 @@ */ SECTIONS { - . = (0x100000000 - 0x10) - (__romstrap_end - __romstrap_start); + . = (0xffffffff - 0x10) - (__romstrap_end - __romstrap_start) + 1; .romstrap (.): { *(.romstrap) } diff --git a/src/southbridge/via/k8t890/romstrap.lds b/src/southbridge/via/k8t890/romstrap.lds index e2f470c8fb..67deebc9e9 100644 --- a/src/southbridge/via/k8t890/romstrap.lds +++ b/src/southbridge/via/k8t890/romstrap.lds @@ -22,7 +22,7 @@ /* Modified for K8T890 ROM strap by Rudolf Marek <r.marek@assembler.cz>. */ SECTIONS { - . = (0x100000000 - 0x2c) - (__romstrap_end - __romstrap_start); + . = (0xffffffff - 0x2c) - (__romstrap_end - __romstrap_start) + 1; .romstrap (.): { *(.romstrap) } |