summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Roth <gaumless@gmail.com>2015-01-06 21:02:52 -0700
committerMartin Roth <gaumless@gmail.com>2015-01-12 21:29:38 +0100
commit98b698c94fc9e378b551ff466bd829550d42fa50 (patch)
treee4e64812617c5b94ec2b39bb5b91065de3923ddd
parent97ccefdaf34ea2f4e2527d98465cb3b96fcf436d (diff)
downloadcoreboot-98b698c94fc9e378b551ff466bd829550d42fa50.tar.xz
src/device: Doxygen fixes
- Add missing parameters - add missing @param commands Change-Id: I029b5dafde94bd250800b06c0e9bd2118f10ef48 Signed-off-by: Martin Roth <gaumless@gmail.com> Reviewed-on: http://review.coreboot.org/8173 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
-rw-r--r--src/device/dram/ddr3.c11
-rw-r--r--src/device/pci_device.c4
2 files changed, 12 insertions, 3 deletions
diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c
index 86abea81a7..8170ae17da 100644
--- a/src/device/dram/ddr3.c
+++ b/src/device/dram/ddr3.c
@@ -18,7 +18,7 @@
*/
/**
- * @file ddr3_util.h
+ * @file ddr3.c
*
* \brief Utilities for decoding DDR3 SPDs
*/
@@ -452,8 +452,13 @@ static u16 ddr3_cas_to_mr0_map(u8 cas)
* write_recovery and cas are given in clock cycles. For example, a CAS of 7T
* should be given as 7.
*
+ * @param precharge_pd
* @param write_recovery Write recovery latency, tWR in clock cycles.
+ * @param dll_reset
+ * @param mode
* @param cas CAS latency in clock cycles.
+ * @param burst_type
+ * @param burst_length
*/
mrs_cmd_t ddr3_get_mr0(enum ddr3_mr0_precharge precharge_pd,
u8 write_recovery,
@@ -555,8 +560,12 @@ mrs_cmd_t ddr3_get_mr1(enum ddr3_mr1_qoff qoff,
* cas_cwl is given in clock cycles. For example, a cas_cwl of 7T should be
* given as 7.
*
+ * @param rtt_wr
+ * @param extended_temp
+ * @param self_refresh
* @param cas_cwl CAS write latency in clock cycles.
*/
+
mrs_cmd_t ddr3_get_mr2(enum ddr3_mr2_rttwr rtt_wr,
enum ddr3_mr2_srt_range extended_temp,
enum ddr3_mr2_asr self_refresh, u8 cas_cwl)
diff --git a/src/device/pci_device.c b/src/device/pci_device.c
index 22454d631f..862ed0e783 100644
--- a/src/device/pci_device.c
+++ b/src/device/pci_device.c
@@ -818,8 +818,8 @@ static struct device_operations *get_pci_bridge_ops(device_t dev)
* The driver entry can either point at a zero terminated array of acceptable
* device IDs, or include a single device ID.
*
- * @driver pointer to the PCI driver entry being checked
- * @device_id PCI device ID of the device being matched
+ * @param driver pointer to the PCI driver entry being checked
+ * @param device_id PCI device ID of the device being matched
*/
static int device_id_match(struct pci_driver *driver, unsigned short device_id)
{