summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2016-07-14 01:38:31 -0500
committerAaron Durbin <adurbin@chromium.org>2016-07-15 08:30:53 +0200
commit9fe0ff2f832dc58bfbb51032a7565c75e24a36c1 (patch)
tree4d8b82f782473fcf4e3a4da573681169a0fa958c
parent30b0c7adf0a5d77a8e902dbbf0ee68954bf28385 (diff)
downloadcoreboot-9fe0ff2f832dc58bfbb51032a7565c75e24a36c1.tar.xz
mainboards: remove direct acpi_slp_type usage
Use the acpi_is_wakeup_s3() API instead of comparing a raw value to a global variable. This allows for easier refactoring. Change-Id: I2813b5d275cbe700be713272e3a88fdb5759db99 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/15690 Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Lee Leahy <leroy.p.leahy@intel.com> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
-rw-r--r--src/mainboard/google/cyan/ec.c2
-rw-r--r--src/mainboard/google/ninja/ec.c2
-rw-r--r--src/mainboard/intel/strago/ec.c2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/google/cyan/ec.c b/src/mainboard/google/cyan/ec.c
index 8f516cb7da..cce7d705e1 100644
--- a/src/mainboard/google/cyan/ec.c
+++ b/src/mainboard/google/cyan/ec.c
@@ -28,7 +28,7 @@ void mainboard_ec_init(void)
#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
/* Restore SCI event mask on resume. */
- if (acpi_slp_type == 3) {
+ if (acpi_is_wakeup_s3()) {
google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
MAINBOARD_EC_S3_WAKE_EVENTS);
diff --git a/src/mainboard/google/ninja/ec.c b/src/mainboard/google/ninja/ec.c
index 994b211a03..147cded0e9 100644
--- a/src/mainboard/google/ninja/ec.c
+++ b/src/mainboard/google/ninja/ec.c
@@ -26,7 +26,7 @@ void mainboard_ec_init(void)
post_code(0xf0);
/* Restore SCI event mask on resume. */
- if (acpi_slp_type == 3) {
+ if (acpi_is_wakeup_s3()) {
google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
MAINBOARD_EC_S3_WAKE_EVENTS);
diff --git a/src/mainboard/intel/strago/ec.c b/src/mainboard/intel/strago/ec.c
index 0f8c55d9b8..dabe274fbf 100644
--- a/src/mainboard/intel/strago/ec.c
+++ b/src/mainboard/intel/strago/ec.c
@@ -28,7 +28,7 @@ void mainboard_ec_init(void)
#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
/* Restore SCI event mask on resume. */
- if (acpi_slp_type == 3) {
+ if (acpi_is_wakeup_s3()) {
google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
MAINBOARD_EC_S3_WAKE_EVENTS);