summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Reinauer <stefan.reinauer@coreboot.org>2015-12-17 13:03:11 -0800
committerMartin Roth <martinroth@google.com>2015-12-30 20:30:17 +0100
commitd09a8819883e3d6784a359e7f25358f4012af24b (patch)
tree97ec12fdeb10d77b73780ec6e02a61a3c2e8e8e7
parentda1ca20ac3481e8108863b5bdc32faff38f7b740 (diff)
downloadcoreboot-d09a8819883e3d6784a359e7f25358f4012af24b.tar.xz
drivers/xgi/common: Fix XGI_SetGroup2
This code looks like it was created from a disassembly of some other driver. Attempt to fix it, without hardware or documentation. CID 142909: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) Change-Id: I9b9cadf2acdba73913aad6bbe0d14ad64a652915 Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Reviewed-on: https://review.coreboot.org/12774 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: Raptor Engineering Automated Test Stand <noreply@raptorengineeringinc.com> Reviewed-by: Martin Roth <martinroth@google.com> Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Reviewed-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
-rw-r--r--src/drivers/xgi/common/vb_setmode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/xgi/common/vb_setmode.c b/src/drivers/xgi/common/vb_setmode.c
index 91e4929ef0..0143076a44 100644
--- a/src/drivers/xgi/common/vb_setmode.c
+++ b/src/drivers/xgi/common/vb_setmode.c
@@ -3616,7 +3616,7 @@ static void XGI_SetGroup2(unsigned short ModeNo, unsigned short ModeIdIndex,
| (tempax & 0x00FF));
temp = (tempax & 0xFF00) >> 8;
} else {
- temp = (tempax & 0x00FF) >> 8;
+ temp = (tempax & 0x00FF);
}
xgifb_reg_set(pVBInfo->Part2Port, 0x44, temp);