summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2019-06-11 14:13:04 -0600
committerMartin Roth <martinroth@google.com>2019-06-28 19:27:15 +0000
commitd10680bbbfc045627625ca0ce79e04491978cedf (patch)
tree8893d10ea226c3acb72dbd74d5deec7a559d0fa0
parent93064ff7cd348f143b9c890a15b65680d3265525 (diff)
downloadcoreboot-d10680bbbfc045627625ca0ce79e04491978cedf.tar.xz
nb/intel/pineview: Remove unused code
All the clocks are switched on anyway, so this series of if statements isn't needed. Change-Id: I654043fd6736caa6890fd697015c577ddaa7cd41 Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Found-by: Coverity CID 13473{27-30} Reviewed-on: https://review.coreboot.org/c/coreboot/+/33408 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/northbridge/intel/pineview/raminit.c11
1 files changed, 1 insertions, 10 deletions
diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index 72063cbdad..1d24ea2217 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -1141,16 +1141,7 @@ static void sdram_dlltiming(struct sysinfo *s)
MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 1;
MCHBAR32(0x1a0) = 0x551803;
- if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0)) {
- reg8 = 0x3c;
- } else if (ONLY_DIMMB_IS_POPULATED(s->dimms, 0)) {
- reg8 = 0x27;
- } else if (BOTH_DIMMS_ARE_POPULATED(s->dimms, 0)) {
- reg8 = 0x24;
- } else {
- // None
- reg8 = 0x3f;
- }
+
reg8 = 0x00; //switch all clocks on anyway
MCHBAR32(0x5a0) = (MCHBAR32(0x5a0) & ~0x3f000000) | (reg8 << 24);