summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexandru Gagniuc <alexandrux.gagniuc@intel.com>2016-05-10 14:46:07 -0700
committerAaron Durbin <adurbin@chromium.org>2016-05-12 04:01:58 +0200
commite22f536bf8b5fb2d41f27c31f527d0ff59d9dd7d (patch)
tree375ece48f30f28e0cf3727f29ec6139f1f116bc1
parent74d06f25541dec1cf5063e057d02228c040f409d (diff)
downloadcoreboot-e22f536bf8b5fb2d41f27c31f527d0ff59d9dd7d.tar.xz
soc/apollolake/uart.c: Do not NOOP .set_resources() and friends
When SOC_UART_DEBUG was not set, the boot would hang somwhere in ramstage, as evidenced by POST codes reported from the EC. This was traced to the .set_resources and .enable_resources members of the UART PCI driver being set to NOOP. Although the exact mechanism of failure is not known, this change eliminates the hang. Change-Id: Ic2f3d56a964ec890ebfa1e1a7770f1ae2eb22281 Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc@intel.com> Reviewed-on: https://review.coreboot.org/14771 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
-rw-r--r--src/soc/intel/apollolake/uart.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/apollolake/uart.c b/src/soc/intel/apollolake/uart.c
index 79f8a54e69..7b50a21575 100644
--- a/src/soc/intel/apollolake/uart.c
+++ b/src/soc/intel/apollolake/uart.c
@@ -42,8 +42,8 @@ static void aplk_uart_read_resources(struct device *dev)
static struct device_operations uart_ops = {
.read_resources = aplk_uart_read_resources,
- .set_resources = DEVICE_NOOP,
- .enable_resources = DEVICE_NOOP,
+ .set_resources = pci_dev_set_resources,
+ .enable_resources = pci_dev_enable_resources,
.init = pci_dev_init,
.enable = DEVICE_NOOP
};