diff options
| author | Keith Hui <buurin@gmail.com> | 2020-01-12 18:41:26 -0500 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-01-26 08:15:35 +0000 |
| commit | e9b3fd1d5da628c7207701ead053a318235c86b3 (patch) | |
| tree | c26c3de6cdee0ab514b05fd166e152481ff770d9 | |
| parent | d6f259e834e67119d913dac86f24a842643847b3 (diff) | |
| download | coreboot-e9b3fd1d5da628c7207701ead053a318235c86b3.tar.xz | |
intel/i440bx: Resolve long standing raminit TODOs
Drop DRAMT write as it's only rewriting the power on default.
PMCR write is required. Update comment on its purpose and move to
end of sdram_enable().
Change-Id: I62e8b2531f0f297ffb7db440db89ffa65771b7d5
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38383
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/northbridge/intel/i440bx/raminit.c | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c index d5c23cf165..0a864e864a 100644 --- a/src/northbridge/intel/i440bx/raminit.c +++ b/src/northbridge/intel/i440bx/raminit.c @@ -357,10 +357,7 @@ static const u8 register_values[] = { * 1 = Enable * 0 = Disable */ - /* Enable normal refresh and the gated clock. */ - // TODO: Only do this later? - // PMCR, 0x00, 0x14, - PMCR, 0x00, 0x00, + /* PMCR will be set later. */ /* Enable SCRR.SRRAEN and let BX choose the SRR. */ SCRR + 1, 0x00, 0x10, @@ -985,13 +982,6 @@ static void sdram_set_spd_registers(void) /* Setup DRAM buffer strength. */ set_dram_buffer_strength(); - - /* TODO: Set PMCR? */ - // pci_write_config8(NB, PMCR, 0x14); - pci_write_config8(NB, PMCR, 0x10); - - /* TODO: This is for EDO memory only. */ - pci_write_config8(NB, DRAMT, 0x03); } static void sdram_enable(void) @@ -1030,7 +1020,7 @@ static void sdram_enable(void) /* 6. Finally enable refresh. */ PRINT_DEBUG("RAM Enable 6: Enable refresh\n"); - // pci_write_config8(NB, PMCR, 0x10); + pci_write_config8(NB, PMCR, 0x10); spd_enable_refresh(); udelay(1); |