summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniele Forsi <dforsi@gmail.com>2014-07-26 11:32:16 +0200
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-07-28 23:13:48 +0200
commitf9ce88e942a70a1aaa1f0951f8fab436a2ea82f5 (patch)
treea8a0a4ba6a77138e2c02a337961226236a78c29a
parentc2519e5a06ba5f70bfcb1e2e70ade440c9552f18 (diff)
downloadcoreboot-f9ce88e942a70a1aaa1f0951f8fab436a2ea82f5.tar.xz
device/oprom/realmode/x86.c: Fix memory leak
Do not allocate memory if the bootsplash was not found. Found by Cppcheck 1.65. Fixes: [src/device/oprom/realmode/x86.c:280]: (error) Memory leak: decdata Change-Id: I8f8160d3d349c0c2b2a3ed84461729e9210153d8 Signed-off-by: Daniele Forsi <dforsi@gmail.com> Reviewed-on: http://review.coreboot.org/6376 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
-rw-r--r--src/device/oprom/realmode/x86.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c
index e25c536e1c..4338e6e53a 100644
--- a/src/device/oprom/realmode/x86.c
+++ b/src/device/oprom/realmode/x86.c
@@ -270,7 +270,6 @@ void vbe_set_graphics(void)
vbe_set_mode(&mode_info);
#if CONFIG_BOOTSPLASH
struct jpeg_decdata *decdata;
- decdata = malloc(sizeof(*decdata));
unsigned char *jpeg = cbfs_get_file_content(CBFS_DEFAULT_MEDIA,
"bootsplash.jpg",
CBFS_TYPE_BOOTSPLASH,
@@ -279,6 +278,7 @@ void vbe_set_graphics(void)
printk(BIOS_DEBUG, "VBE: No bootsplash found.\n");
return;
}
+ decdata = malloc(sizeof(*decdata));
int ret = 0;
ret = jpeg_decode(jpeg, framebuffer, 1024, 768, 16, decdata);
#endif