diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2016-03-31 14:00:47 -0500 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2016-04-02 03:57:37 +0200 |
| commit | faa74b0fb81b3a1dd3e37f05774a24446057228a (patch) | |
| tree | fcab9377c6fa90f81b54e81307a6945f1cbce5e1 | |
| parent | 096f45792670acbd3c68cf01c07aad679f831d3d (diff) | |
| download | coreboot-faa74b0fb81b3a1dd3e37f05774a24446057228a.tar.xz | |
soc/intel/apollolake: use platform_segment_loaded() for CAR coherency
Instead of using arch_segment_loaded() implement
platform_segment_loaded() so as not to tangle the notion of
arch and the chipset. Lastly, add a TODO to allow filtering
of the L1D to L2 flush depending on the region loaded.
Change-Id: I52e7cd2ae6e2d95f21bdd2fe1a471a10565309cb
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/14215
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Andrey Petrov <andrey.petrov@intel.com>
| -rw-r--r-- | src/soc/intel/apollolake/car.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/soc/intel/apollolake/car.c b/src/soc/intel/apollolake/car.c index c49d7ef187..b0a5b4550c 100644 --- a/src/soc/intel/apollolake/car.c +++ b/src/soc/intel/apollolake/car.c @@ -26,8 +26,10 @@ static void flush_l1d_to_l2(void) wrmsr(MSR_POWER_MISC, msr); } -void arch_segment_loaded(uintptr_t start, size_t size, int flags) +void platform_segment_loaded(uintptr_t start, size_t size, int flags) { + /* TODO: filter on address to see if L1D flushing required. */ + /* Flush L1D cache to L2 on final segment loaded */ if (flags & SEG_FINAL) flush_l1d_to_l2(); |