summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRicardo Ribalda <ribalda@chromium.org>2020-10-29 15:00:26 +0100
committerPatrick Georgi <pgeorgi@google.com>2020-11-09 07:41:37 +0000
commit2b13ca5bcdc15b894665c7f0a0d26c45c1e46efc (patch)
tree66c2e215d011128591e31ff8eabeeed937025b99
parent43d0a7e66c1503a9fbd9f8653861a343a3225f45 (diff)
downloadcoreboot-2b13ca5bcdc15b894665c7f0a0d26c45c1e46efc.tar.xz
mb/google/volteer/eldrid: Describe the privacy_gpio
Add information regarding the privacy pin on the overridetree and the gpio. BUG=b:171888751 Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46964 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
-rw-r--r--src/mainboard/google/volteer/Kconfig1
-rw-r--r--src/mainboard/google/volteer/variants/eldrid/gpio.c2
-rw-r--r--src/mainboard/google/volteer/variants/eldrid/overridetree.cb4
3 files changed, 6 insertions, 1 deletions
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 23dbf68fe9..a5cc1966dc 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -14,6 +14,7 @@ config BOARD_GOOGLE_BASEBOARD_VOLTEER
select DRIVERS_SPI_ACPI
select DRIVERS_SOUNDWIRE_ALC5682
select DRIVERS_SOUNDWIRE_MAX98373
+ select DRIVERS_USB_ACPI
select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_BOARDID
select EC_GOOGLE_CHROMEEC_SKUID
diff --git a/src/mainboard/google/volteer/variants/eldrid/gpio.c b/src/mainboard/google/volteer/variants/eldrid/gpio.c
index 4f6650b2f9..3d627e3b81 100644
--- a/src/mainboard/google/volteer/variants/eldrid/gpio.c
+++ b/src/mainboard/google/volteer/variants/eldrid/gpio.c
@@ -63,7 +63,7 @@ static const struct pad_config override_gpio_table[] = {
PAD_CFG_GPO(GPP_C23, 1, DEEP),
/* D4 : IMGCLKOUT0# ==> CAMMERA_SWITCH */
- PAD_CFG_GPI(GPP_D4, NONE, DEEP),
+ PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH),
/* D6 : SRCCLKREQ1# ==> WLAN_CLKREQ_ODL */
PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1),
/* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL */
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index 249505fc41..91fbbea5d0 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -227,6 +227,10 @@ chip soc/intel/tigerlake
chip drivers/usb/acpi
register "desc" = ""USB2 Camera""
register "type" = "UPC_TYPE_INTERNAL"
+ # The Linux Kernel does not allow an inverted BOTH_EDGE irq
+ # So we need to use GpioIO() instead of GpioInt()
+ # https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt
+ register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)"
device ref usb2_port5 on end
end
chip drivers/usb/acpi