diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-11-01 09:12:34 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-11-03 06:17:20 +0000 |
| commit | 463ad5169dfe958637c7514149bd91630ee07f7e (patch) | |
| tree | 18885045c46194d22b384a223962207ed6078005 | |
| parent | ddd6ca78a1ec57d8549393124a3e5fbad0cdf362 (diff) | |
| download | coreboot-463ad5169dfe958637c7514149bd91630ee07f7e.tar.xz | |
boot_state: Reduce precision of reported times
When diffing boot logs, lines reporting times spent in each
boot_state always get highlighed due the little fluctuation
in microsecond-scale. Reduce the logged precision to
milliseconds to avoid that.
Change-Id: I7a27d6c250d8432131f30e9a4869cb45ad75d9fd
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36528
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/lib/hardwaremain.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c index 2ff2b8c874..51ff330d84 100644 --- a/src/lib/hardwaremain.c +++ b/src/lib/hardwaremain.c @@ -23,6 +23,7 @@ #include <bootstate.h> #include <console/console.h> #include <console/post_codes.h> +#include <commonlib/helpers.h> #include <cbmem.h> #include <version.h> #include <device/device.h> @@ -256,7 +257,12 @@ static void bs_report_time(struct boot_state *state) run_time = mono_time_diff_microseconds(&samples[1], &samples[2]); exit_time = mono_time_diff_microseconds(&samples[2], &samples[3]); - printk(BIOS_DEBUG, "BS: %s times (us): entry %ld run %ld exit %ld\n", + /* Report with millisecond precision to reduce log diffs. */ + entry_time = DIV_ROUND_CLOSEST(entry_time, USECS_PER_MSEC); + run_time = DIV_ROUND_CLOSEST(run_time, USECS_PER_MSEC); + exit_time = DIV_ROUND_CLOSEST(exit_time, USECS_PER_MSEC); + + printk(BIOS_DEBUG, "BS: %s times (ms): entry %ld run %ld exit %ld\n", state->name, entry_time, run_time, exit_time); } #else |