diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2018-01-16 17:22:20 +0100 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@gmail.com> | 2018-02-01 18:57:28 +0000 |
| commit | 4ad1f7d67e9bd11537557013663d60095efd4a01 (patch) | |
| tree | cc2d3c957cc5aa1e6842d68c22b2abc835252fcc | |
| parent | 823dbde2abb116575ce183f73cce332a4d5a9c8e (diff) | |
| download | coreboot-4ad1f7d67e9bd11537557013663d60095efd4a01.tar.xz | |
Add a default path for vbt.bin
FSP_GOP needs a vbt.bin to work but before this patch it was able to
build with the default configuration which was an empty path for
vbt.bin.
To make Jenkins happy don't select FSP_GOP by default, at least until
all boards have the proper vbt blobs in the blobs repo.
Change-Id: Ibc36d6d4dd1a56c53819b169e6f4799ce3c23e03
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/23290
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
| -rw-r--r-- | src/device/Kconfig | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/src/device/Kconfig b/src/device/Kconfig index 82caa96be1..a36b2e1f4d 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -82,15 +82,6 @@ config MAINBOARD_USE_LIBGFXINIT Use the SPARK library `libgfxinit` for the native graphics initialization. This requires an Ada toolchain. -config RUN_FSP_GOP - bool "Run a GOP driver" - depends on HAVE_FSP_GOP - select HAVE_LINEAR_FRAMEBUFFER - help - Some platforms (e.g. Intel Braswell and Skylake/Kaby Lake) support - to run a GOP blob. This option enables graphics initialization with - such a blob. - # TODO: Explain differences (if any) for onboard cards. config VGA_ROM_RUN bool "Run VGA Option ROMs" @@ -105,6 +96,15 @@ config VGA_ROM_RUN more complete BIOS interrupt services available than coreboot, which some option ROMs require in order to function correctly. +config RUN_FSP_GOP + bool "Run a GOP driver" + depends on HAVE_FSP_GOP + select HAVE_LINEAR_FRAMEBUFFER + help + Some platforms (e.g. Intel Braswell and Skylake/Kaby Lake) support + to run a GOP blob. This option enables graphics initialization with + such a blob. + config NO_GFX_INIT bool "None" depends on !MAINBOARD_FORCE_NATIVE_VGA_INIT @@ -609,6 +609,7 @@ config INTEL_GMA_ADD_VBT_DATA_FILE config INTEL_GMA_VBT_FILE string "VBT binary path and filename" depends on INTEL_GMA_ADD_VBT_DATA_FILE + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/vbt.bin" help The path and filename of the VBT binary. |