summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <patrick@georgi-clan.de>2014-12-06 17:35:25 +0100
committerPatrick Georgi <pgeorgi@google.com>2014-12-29 11:14:34 +0100
commit8b12a281167061fbea59948cc5c69d4117a5897b (patch)
tree20b4b29d754b1e7e9d91846370fd1933f7d59104
parent63f6dc79db821caf24320dbee0dd652a80f2996e (diff)
downloadcoreboot-8b12a281167061fbea59948cc5c69d4117a5897b.tar.xz
edid: fill reserved bits fields in cb_framebuffer
If it's a 4 byte format (as per documentation), there are some reserved bits, so let's mark them as such... Unfortunately undone while upstreaming changes. Change-Id: I50f12cfff2c9bb9d082a5f3c3ac54c0d514d862c Signed-off-by: Patrick Georgi <patrick@georgi-clan.de> Originally-Reviewed-on: http://review.coreboot.org/7674 Reviewed-on: http://review.coreboot.org/7964 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
-rw-r--r--src/lib/edid.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/lib/edid.c b/src/lib/edid.c
index c047b51834..4d2d55db7b 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1456,10 +1456,14 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
* I'm not sure with grahpics you ever can.
*/
edid_fb.bits_per_pixel = edid->framebuffer_bits_per_pixel;
+ edid_fb.reserved_mask_pos = 0;
+ edid_fb.reserved_mask_size = 0;
switch(edid->framebuffer_bits_per_pixel){
case 32:
case 24:
/* packed into 4-byte words */
+ edid_fb.reserved_mask_pos = 24;
+ edid_fb.reserved_mask_size = 8;
edid_fb.red_mask_pos = 16;
edid_fb.red_mask_size = 8;
edid_fb.green_mask_pos = 8;
@@ -1482,8 +1486,6 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
return;
}
- edid_fb.reserved_mask_pos = 0;
- edid_fb.reserved_mask_size = 0;
vbe_valid = 1;
}