diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-01-09 08:41:46 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-01-10 14:11:50 +0000 |
| commit | 8b93cb756cda7437bff13a34dba1b2754e306ab8 (patch) | |
| tree | cb36e958bab163e59b54cae0eed9da18f06162d8 | |
| parent | 37bf996efb16aa48fb0270b38b3c83633c3bf784 (diff) | |
| download | coreboot-8b93cb756cda7437bff13a34dba1b2754e306ab8.tar.xz | |
timestamps: Fix TIMESTAMPS_ON_CONSOLE behaviour
As logging is guarded by Kconfig, increase the level from BIOS_SPEW
to BIOS_INFO.
The original callsite inside timestamp_add_table_entry() was also
called when syncing from timestamps from .bss to CBMEM. We should
not reprint the values then.
Change-Id: I72ca4b6a04d8734c141a04e651fc8c23932b1f23
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38300
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
| -rw-r--r-- | src/Kconfig | 2 | ||||
| -rw-r--r-- | src/lib/timestamp.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/Kconfig b/src/Kconfig index 762cf8901b..9118914e3c 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -224,7 +224,7 @@ config TIMESTAMPS_ON_CONSOLE default n depends on COLLECT_TIMESTAMPS help - Print the timestamps to the debug console if enabled at level spew. + Print the timestamps to the debug console if enabled at level info. config USE_BLOBS bool "Allow use of binary-only repository" diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index 7c7210cc5a..d2206f6134 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -130,9 +130,6 @@ static void timestamp_add_table_entry(struct timestamp_table *ts_table, tse->entry_id = id; tse->entry_stamp = ts_time - ts_table->base_time; - if (CONFIG(TIMESTAMPS_ON_CONSOLE)) - printk(BIOS_SPEW, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time); - if (ts_table->num_entries == ts_table->max_entries) printk(BIOS_ERR, "ERROR: Timestamp table full\n"); } @@ -152,6 +149,9 @@ void timestamp_add(enum timestamp_id id, uint64_t ts_time) } timestamp_add_table_entry(ts_table, id, ts_time); + + if (CONFIG(TIMESTAMPS_ON_CONSOLE)) + printk(BIOS_INFO, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time); } void timestamp_add_now(enum timestamp_id id) |