diff options
| author | Patrick Georgi <pgeorgi@chromium.org> | 2016-07-29 18:37:56 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-07-31 19:00:00 +0200 |
| commit | 90ed31beac54f6380a78a4b3c51c8fab434db95b (patch) | |
| tree | 3d9dd85e4d38c063e9ee8f33ed4e78046b2d77d2 | |
| parent | bce1807d9c06c921381ed69343ccf4cfb145308a (diff) | |
| download | coreboot-90ed31beac54f6380a78a4b3c51c8fab434db95b.tar.xz | |
intel/skylake: Enable signalling of error condition
Testing for "devfn < 0" on an unsigned doesn't work, and i2c_bus_to_devfn
returns an int (with -1 for "error"), so use int for devfn.
Change-Id: I7d1cdb6af4140f7dc322141c0c018d8418627434
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Found-by: Coverity Scan #1357450, #1357449
Reviewed-on: https://review.coreboot.org/15964
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
| -rw-r--r-- | src/soc/intel/skylake/romstage/i2c.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/skylake/romstage/i2c.c b/src/soc/intel/skylake/romstage/i2c.c index 3d2e9945c0..f6d1384a4b 100644 --- a/src/soc/intel/skylake/romstage/i2c.c +++ b/src/soc/intel/skylake/romstage/i2c.c @@ -27,7 +27,7 @@ uintptr_t lpss_i2c_base_address(unsigned bus) { - unsigned devfn; + int devfn; pci_devfn_t dev; /* Find device+function for this controller */ @@ -49,7 +49,7 @@ static void i2c_early_init_bus(unsigned bus) const struct lpss_i2c_speed_config *sptr; enum i2c_speed speed; pci_devfn_t dev; - unsigned devfn; + int devfn; uintptr_t base; uint32_t value; void *reg; |