summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Lemenkov <lemenkov@gmail.com>2019-12-26 21:02:24 +0300
committerPatrick Georgi <pgeorgi@google.com>2019-12-27 09:09:20 +0000
commit9fadd9a917c15d76067825073afb683e90ac19b1 (patch)
tree8da961a529ce9c9d1c571948ba23e7e0fa37aad6
parent6c2c018e15a1c4d3ae394333263e6c7c3eb30415 (diff)
downloadcoreboot-9fadd9a917c15d76067825073afb683e90ac19b1.tar.xz
mb/lenovo/*/acpi_tables: Don't zero out gnvs again
The gnvs structure was zeroed out already in the following files: * src/southbridge/intel/i82801ix/lpc.c (t400 and x200) * src/southbridge/intel/i82801gx/lpc.c (thinkcentre_a58) Change-Id: Id7d552e1c4084a0b36b98f9627a85a75c8b90e81 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37937 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
-rw-r--r--src/mainboard/lenovo/t400/acpi_tables.c1
-rw-r--r--src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c2
-rw-r--r--src/mainboard/lenovo/x200/acpi_tables.c1
3 files changed, 0 insertions, 4 deletions
diff --git a/src/mainboard/lenovo/t400/acpi_tables.c b/src/mainboard/lenovo/t400/acpi_tables.c
index 85a3d7eeda..6fed293f78 100644
--- a/src/mainboard/lenovo/t400/acpi_tables.c
+++ b/src/mainboard/lenovo/t400/acpi_tables.c
@@ -24,7 +24,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
- memset((void *)gnvs, 0, sizeof(*gnvs));
gnvs->apic = 1;
gnvs->mpen = 1; /* Enable Multi Processing */
diff --git a/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c b/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c
index 666bba63e3..c607c32326 100644
--- a/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c
+++ b/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c
@@ -20,8 +20,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
- memset((void *)gnvs, 0, sizeof(*gnvs));
-
gnvs->pwrs = 1; /* Power state (AC = 1) */
gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/lenovo/x200/acpi_tables.c b/src/mainboard/lenovo/x200/acpi_tables.c
index 85a3d7eeda..6fed293f78 100644
--- a/src/mainboard/lenovo/x200/acpi_tables.c
+++ b/src/mainboard/lenovo/x200/acpi_tables.c
@@ -24,7 +24,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
- memset((void *)gnvs, 0, sizeof(*gnvs));
gnvs->apic = 1;
gnvs->mpen = 1; /* Enable Multi Processing */