diff options
| author | Furquan Shaikh <furquan@google.com> | 2020-07-14 18:50:43 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2020-07-16 16:45:57 +0000 |
| commit | bf6541d876fad1ce518bf6c36d4448007d4e44c7 (patch) | |
| tree | d4dbd9edbdb5f80454b4bd627d29344e8879a24a | |
| parent | bf9eb00c11b6940051a6bb5234f28ff567f2e748 (diff) | |
| download | coreboot-bf6541d876fad1ce518bf6c36d4448007d4e44c7.tar.xz | |
soc/amd/picasso: Drop mainboard_romstage_entry_s3
mainboard_romstage_entry_s3() was dropped from zork (CB:43476). This
function call in picasso does not do anything and hence is being dropped.
BUG=b:154351731
Signed-off-by: Furquan Shaikh <furquan@google.com>
Change-Id: I10e15422d7eef5af9c19737c32e433718b6479d6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43477
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/amd/picasso/include/soc/romstage.h | 8 | ||||
| -rw-r--r-- | src/soc/amd/picasso/romstage.c | 7 |
2 files changed, 0 insertions, 15 deletions
diff --git a/src/soc/amd/picasso/include/soc/romstage.h b/src/soc/amd/picasso/include/soc/romstage.h deleted file mode 100644 index e7ff31a06e..0000000000 --- a/src/soc/amd/picasso/include/soc/romstage.h +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef __PICASSO_ROMSTAGE_H__ -#define __PICASSO_ROMSTAGE_H__ - -void mainboard_romstage_entry_s3(int s3_resume); - -#endif /* __PICASSO_ROMSTAGE_H__ */ diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index 6855bf6129..0a337e7720 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -10,18 +10,12 @@ #include <console/console.h> #include <program_loading.h> #include <elog.h> -#include <soc/romstage.h> #include <soc/memmap.h> #include <soc/mrc_cache.h> #include <types.h> #include "chip.h" #include <fsp/api.h> -void __weak mainboard_romstage_entry_s3(int s3_resume) -{ - /* By default, don't do anything */ -} - void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) { FSP_M_CONFIG *mcfg = &mupd->FspmConfig; @@ -80,7 +74,6 @@ asmlinkage void car_stage_entry(void) post_code(0x41); s3_resume = acpi_s3_resume_allowed() && acpi_is_wakeup_s3(); - mainboard_romstage_entry_s3(s3_resume); post_code(0x42); u32 val = cpuid_eax(1); |