diff options
| author | David Hendricks <dhendrix@chromium.org> | 2013-03-12 21:28:07 -0700 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2013-03-13 16:55:33 +0100 |
| commit | d2bed05e6adc7ea22188917c9551f4cb2d8c949d (patch) | |
| tree | 7f57ecff51b50f212169f5275eb3a751a249bf5e | |
| parent | e0c974185c32a89206cb3037f9a9f35aa0dd82d7 (diff) | |
| download | coreboot-d2bed05e6adc7ea22188917c9551f4cb2d8c949d.tar.xz | |
exynos5250/snow: call PMIC's power_init() function
Call the power_init() function. We appear to have forgotten about it
when deprecating lowlevel_init_subsystems(), but it didn't seem to
cause problems until we got to doing more interesting stuff recently.
There are some clean-ups to do from the original code, such as not
attempting to configure I2C from PMIC code, which we'll get around
to in follow-up patches.
(Credit to Gabe for spotting this)
Change-Id: I6a59379e9323277d0b61469de9abe6d651ac5bfb
Signed-off-by: Gabe Black <gabeblack@chromium.org>
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/2699
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
| -rw-r--r-- | src/cpu/samsung/exynos5250/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/mainboard/google/snow/romstage.c | 7 |
2 files changed, 8 insertions, 0 deletions
diff --git a/src/cpu/samsung/exynos5250/Makefile.inc b/src/cpu/samsung/exynos5250/Makefile.inc index 33fcedcc40..2774b12c28 100644 --- a/src/cpu/samsung/exynos5250/Makefile.inc +++ b/src/cpu/samsung/exynos5250/Makefile.inc @@ -17,6 +17,7 @@ romstage-y += pinmux.c # required by s3c24x0_i2c (exynos5-common) and uart. romstage-y += exynos_cache.c romstage-y += dmc_common.c romstage-y += dmc_init_ddr3.c +romstage-y += power.c romstage-$(CONFIG_EARLY_CONSOLE) += soc.c romstage-$(CONFIG_EARLY_CONSOLE) += uart.c diff --git a/src/mainboard/google/snow/romstage.c b/src/mainboard/google/snow/romstage.c index 83d5105852..c2f5fc9f0a 100644 --- a/src/mainboard/google/snow/romstage.c +++ b/src/mainboard/google/snow/romstage.c @@ -30,6 +30,7 @@ #include <cpu/samsung/exynos5250/gpio.h> #include <cpu/samsung/exynos5250/setup.h> #include <cpu/samsung/exynos5250/periph.h> +#include <cpu/samsung/exynos5250/power.h> #include <cpu/samsung/exynos5250/clock_init.h> #include <console/console.h> #include <arch/stages.h> @@ -90,6 +91,12 @@ void main(void) console_init(); + /* + * FIXME: Do necessary I2C init so low-level PMIC code doesn't need to. + * Also, we should only call power_init() on cold boot. + */ + power_init(); + if (!mem) { printk(BIOS_CRIT, "Unable to auto-detect memory timings\n"); while(1); |