diff options
| author | Kevin Chiu <Kevin.Chiu@quantatw.com> | 2018-08-14 23:20:45 +0800 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2018-08-15 18:30:27 +0000 |
| commit | ea6a3c7d24e4262a73768090b42c7220bf63ada9 (patch) | |
| tree | 9064eff4732533b9ef94f4f0cd21ca595633890d | |
| parent | d7decb82442e0ef7557aa247b4a5a8e56f28b6c2 (diff) | |
| download | coreboot-ea6a3c7d24e4262a73768090b42c7220bf63ada9.tar.xz | |
google/grunt: Remove BayHub EMMC driving strength override
Side effect was observed that after override BayHub EMMC
driving strength to the max, EMMC CLK will be reduced to
51.x Mhz from 200 Mhz.
This will cause OS installation fail on Samsung EMMC sku.
BUG=b:111964336
BRANCH=master
TEST=emerge-grunt coreboot
Change-Id: I848ab0cae474b15fbc4264c8ade63d5c6b4e489d
Signed-off-by: Kevin Chiu <Kevin.Chiu@quantatw.com>
Reviewed-on: https://review.coreboot.org/28084
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
| -rw-r--r-- | src/mainboard/google/kahlee/variants/baseboard/mainboard.c | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c index b1bd4928d2..cf38b99073 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c +++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c @@ -17,8 +17,6 @@ #include <baseboard/variants.h> #include <gpio.h> #include <variant/gpio.h> -#include <device/pci.h> -#include <drivers/generic/bayhub/bh720.h> uint8_t variant_board_sku(void) { @@ -37,26 +35,3 @@ void variant_mainboard_suspend_resume(void) gpio_set(GPIO_133, 0); } #endif - -void bh720_driving_strength(struct device *dev) -{ - u32 sdbar; - u32 bh720_pcr_data; - - sdbar = pci_read_config32(dev, PCI_BASE_ADDRESS_1); - - /* Enable Memory Access Function */ - write32((void *)(sdbar + BH720_MEM_ACCESS_EN), 0x40000000); - write32((void *)(sdbar + BH720_MEM_RW_DATA), 0x80000000); - write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x800000D0); - - /* Read current EMMC 1.8V CLK/DATA,CMD driving strength */ - write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x40000304); - bh720_pcr_data = read32((void *)(sdbar + BH720_MEM_RW_DATA)); - - /* set EMMC 1.8V CLK/DATA,CMD the max level */ - write32((void *)(sdbar + BH720_MEM_RW_DATA), - bh720_pcr_data | (BH720_PCR_CLK_DRV_MAX << 4) | - (BH720_PCR_DATA_CMD_DRV_MAX << 1)); - write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x80000304); -} |