summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2020-10-18 15:03:21 -0700
committerDuncan Laurie <dlaurie@chromium.org>2020-10-21 15:35:42 +0000
commitfcbf18c5df6013c31e99662887be5c4e8bb2cf24 (patch)
tree6518a5929917c07541a1b6b49f72091e2f050908
parentbf6962225659818c308ad323e35f181ce9c9c13b (diff)
downloadcoreboot-fcbf18c5df6013c31e99662887be5c4e8bb2cf24.tar.xz
soc/intel/common: Fix ACPI device name for USB4 DMA device
The USB4 host interface (DMA) devices need to use SA_DEVFN_* instead of SA_DEV_* when determining the ACPI name. The matching names are removed from the SOC-level ACPI name handler since they are provided by this driver now. TEST=boot on volteer and ensure TDM0 device is in the SSDT. Signed-off-by: Duncan Laurie <dlaurie@google.com> Change-Id: If778bda82b80593452a590962dbffef6eff6484a Reviewed-on: https://review.coreboot.org/c/coreboot/+/46543 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
-rw-r--r--src/soc/intel/common/block/usb4/usb4.c4
-rw-r--r--src/soc/intel/tigerlake/chip.c2
2 files changed, 2 insertions, 4 deletions
diff --git a/src/soc/intel/common/block/usb4/usb4.c b/src/soc/intel/common/block/usb4/usb4.c
index 7c545f6043..df2dfdde37 100644
--- a/src/soc/intel/common/block/usb4/usb4.c
+++ b/src/soc/intel/common/block/usb4/usb4.c
@@ -15,9 +15,9 @@
static const char *tbt_dma_acpi_name(const struct device *dev)
{
switch (dev->path.pci.devfn) {
- case SA_DEV_TCSS_DMA0:
+ case SA_DEVFN_TCSS_DMA0:
return "TDM0";
- case SA_DEV_TCSS_DMA1:
+ case SA_DEVFN_TCSS_DMA1:
return "TDM1";
default:
return NULL;
diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c
index 98ed55ca58..46c043fce9 100644
--- a/src/soc/intel/tigerlake/chip.c
+++ b/src/soc/intel/tigerlake/chip.c
@@ -68,8 +68,6 @@ const char *soc_acpi_name(const struct device *dev)
case SA_DEVFN_ROOT: return "MCHC";
case SA_DEVFN_TCSS_XHCI: return "TXHC";
case SA_DEVFN_TCSS_XDCI: return "TXDC";
- case SA_DEVFN_TCSS_DMA0: return "TDM0";
- case SA_DEVFN_TCSS_DMA1: return "TDM1";
case SA_DEVFN_TBT0: return "TRP0";
case SA_DEVFN_TBT1: return "TRP1";
case SA_DEVFN_TBT2: return "TRP2";