diff options
| author | Elyes HAOUAS <ehaouas@noos.fr> | 2019-11-16 09:11:41 +0100 |
|---|---|---|
| committer | Arthur Heymans <arthur@aheymans.xyz> | 2019-11-17 18:45:37 +0000 |
| commit | 05d7d82d37ae04ec4cf3579eb1c0f7bf0c0b7aa2 (patch) | |
| tree | d5af82e40f3b8b6617de0972df490abe27588ac4 | |
| parent | e7087a19bc158e1bbbe6b2bfaef53e38a644f99c (diff) | |
| download | coreboot-05d7d82d37ae04ec4cf3579eb1c0f7bf0c0b7aa2.tar.xz | |
mb/{i945,ich7}: Remove redundant write on V0CTL
RCBA32(V0CTL)= 0x80000001 already done inhere i945/early_init.c
Change-Id: Ia775f4e6158a217b48629d289845537e7ccf5e79
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36877
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Nico Huber <nico.h@gmx.de>
| -rw-r--r-- | src/mainboard/apple/macbook21/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/getac/p470/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/ibase/mb899/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/intel/d945gclf/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/kontron/986lcd-m/early_init.c | 2 | ||||
| -rw-r--r-- | src/mainboard/lenovo/t60/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/lenovo/x60/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/roda/rk886ex/early_init.c | 2 |
8 files changed, 0 insertions, 22 deletions
diff --git a/src/mainboard/apple/macbook21/early_init.c b/src/mainboard/apple/macbook21/early_init.c index d4654de118..081e55ade4 100644 --- a/src/mainboard/apple/macbook21/early_init.c +++ b/src/mainboard/apple/macbook21/early_init.c @@ -20,9 +20,6 @@ void mainboard_late_rcba_config(void) { - /* V0CTL Virtual Channel 0 Resource Control */ - RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(0x3100) = 0x00042210; RCBA32(0x3108) = 0x10004321; diff --git a/src/mainboard/getac/p470/early_init.c b/src/mainboard/getac/p470/early_init.c index 3684c1c943..c75caada6e 100644 --- a/src/mainboard/getac/p470/early_init.c +++ b/src/mainboard/getac/p470/early_init.c @@ -123,9 +123,6 @@ void bootblock_mainboard_early_init(void) void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/ibase/mb899/early_init.c b/src/mainboard/ibase/mb899/early_init.c index ba8d30cf29..0b005022d8 100644 --- a/src/mainboard/ibase/mb899/early_init.c +++ b/src/mainboard/ibase/mb899/early_init.c @@ -99,9 +99,6 @@ void bootblock_mainboard_early_init(void) void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/intel/d945gclf/early_init.c b/src/mainboard/intel/d945gclf/early_init.c index c8dd3619c8..b4818e49ca 100644 --- a/src/mainboard/intel/d945gclf/early_init.c +++ b/src/mainboard/intel/d945gclf/early_init.c @@ -23,9 +23,6 @@ void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - //RCBA32(0x0014) = 0x80000001; - /* dev irq route register */ RCBA16(D31IR) = 0x0132; RCBA16(D30IR) = 0x0146; diff --git a/src/mainboard/kontron/986lcd-m/early_init.c b/src/mainboard/kontron/986lcd-m/early_init.c index 48fe4935ae..31cb20998d 100644 --- a/src/mainboard/kontron/986lcd-m/early_init.c +++ b/src/mainboard/kontron/986lcd-m/early_init.c @@ -144,8 +144,6 @@ void bootblock_mainboard_early_init(void) void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; /* Device 1d interrupt pin register */ diff --git a/src/mainboard/lenovo/t60/early_init.c b/src/mainboard/lenovo/t60/early_init.c index d3de1e4c94..edd167a7ec 100644 --- a/src/mainboard/lenovo/t60/early_init.c +++ b/src/mainboard/lenovo/t60/early_init.c @@ -69,9 +69,6 @@ void bootblock_mainboard_early_init(void) void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - RCBA32(V0CTL) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; RCBA32(D29IP) = 0x40004321; diff --git a/src/mainboard/lenovo/x60/early_init.c b/src/mainboard/lenovo/x60/early_init.c index 459c2461ca..8cf5ab498d 100644 --- a/src/mainboard/lenovo/x60/early_init.c +++ b/src/mainboard/lenovo/x60/early_init.c @@ -68,9 +68,6 @@ void bootblock_mainboard_early_init(void) void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - RCBA32(V0CTL) = 0x80000001; - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; RCBA32(D29IP) = 0x40004321; diff --git a/src/mainboard/roda/rk886ex/early_init.c b/src/mainboard/roda/rk886ex/early_init.c index dff1a6fe03..f3e24e0f3b 100644 --- a/src/mainboard/roda/rk886ex/early_init.c +++ b/src/mainboard/roda/rk886ex/early_init.c @@ -92,8 +92,6 @@ void bootblock_mainboard_early_init(void) void mainboard_late_rcba_config(void) { - /* Set up virtual channel 0 */ - /* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220; |