diff options
| author | Furquan Shaikh <furquan@google.com> | 2018-03-12 06:29:52 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2018-03-13 15:37:17 +0000 |
| commit | 0995b2da3856d3b363c8cb3b011418ae469cc1e4 (patch) | |
| tree | 577a3adc0e236637fd55715eedfd8527d6b501ae | |
| parent | 898e2b4399d97a23f7bf37e5eb1e2947b2f1b149 (diff) | |
| download | coreboot-0995b2da3856d3b363c8cb3b011418ae469cc1e4.tar.xz | |
mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4
Since nami proto did not have any external pull on MEM_CONFIG_4, use a
weak internal pull down before reading it.
BUG=b:74420123
TEST=Verified that the value read for MEM_CONFIG_4 is correct on nami.
Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/25103
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | src/mainboard/google/poppy/variants/nami/memory.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/poppy/variants/nami/memory.c b/src/mainboard/google/poppy/variants/nami/memory.c index 6aa0e7610f..082b9a4417 100644 --- a/src/mainboard/google/poppy/variants/nami/memory.c +++ b/src/mainboard/google/poppy/variants/nami/memory.c @@ -82,7 +82,7 @@ static void fill_ddr4_memory_params(struct memory_params *p) void variant_memory_params(struct memory_params *p) { memset(p, 0, sizeof(*p)); - gpio_input(GPIO_MEM_CONFIG_4); + gpio_input_pulldown(GPIO_MEM_CONFIG_4); if (gpio_get(GPIO_MEM_CONFIG_4)) /* set to LPDDR3 */ fill_lpddr3_memory_params(p); |