diff options
| author | Subrata Banik <subrata.banik@intel.com> | 2017-12-07 15:32:32 +0530 |
|---|---|---|
| committer | Subrata Banik <subrata.banik@intel.com> | 2017-12-13 10:20:41 +0000 |
| commit | 1156c6656a3811bb57ede90521a0651f1f89065b (patch) | |
| tree | 9d9ae8532b9e906da2f447f06567de167b8819dd | |
| parent | 5c619a285cd47ffafcb28872d52495b0eef2ea77 (diff) | |
| download | coreboot-1156c6656a3811bb57ede90521a0651f1f89065b.tar.xz | |
soc/intel/apollolake: Remove set_subsystem() from SoC
Intel common PCI driver is handle PCI subsystem ID
programming, hence no need to have an explicit soc
function to do the same.
TEST=PCI subsystem id is getting programming during
pci enumeration.
Change-Id: I3eb362ff1f3f6d5c81a0dbe854d8ecd59d5a0453
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/22770
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
| -rw-r--r-- | src/soc/intel/apollolake/chip.c | 14 | ||||
| -rw-r--r-- | src/soc/intel/apollolake/chip.h | 1 |
2 files changed, 0 insertions, 15 deletions
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 1e78cb1f1d..53ffdb9f84 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -117,20 +117,6 @@ static const char *soc_acpi_name(const struct device *dev) return NULL; } -static void pci_set_subsystem(device_t dev, unsigned vendor, unsigned device) -{ - if (!vendor || !device) - pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, - pci_read_config32(dev, PCI_VENDOR_ID)); - else - pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, - (device << 16) | vendor); -} - -struct pci_operations soc_pci_ops = { - .set_subsystem = &pci_set_subsystem -}; - static void pci_domain_set_resources(device_t dev) { assign_resources(dev->link_list); diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 92e814b622..7416327dbe 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -148,6 +148,5 @@ struct soc_intel_apollolake_config { }; typedef struct soc_intel_apollolake_config config_t; -extern struct pci_operations soc_pci_ops; #endif /* _SOC_APOLLOLAKE_CHIP_H_ */ |