diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-10 17:48:31 -0800 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-03-13 21:23:58 +0100 |
| commit | 3e1cab447b648e5cfdaa55d098075ddd5ede0efc (patch) | |
| tree | 44ce75b2b6a43330dc39c3eefd5ff424925ba966 | |
| parent | 49fd42dc65d6686f11eff691e37371ea6130a902 (diff) | |
| download | coreboot-3e1cab447b648e5cfdaa55d098075ddd5ede0efc.tar.xz | |
src/lib: Remove unnecessary code
Fix the following warnings detected by checkpatch.pl:
WARNING: break is not useful after a goto or return
WARNING: Statements terminations use 1 semicolon
WARNING: else is not generally useful after a break or return
WARNING: void function return statements are not generally useful
TEST=Build and run on Galileo Gen2
Change-Id: I6f095c4e9cb1ee4ff2ebdf095ef612e1a8393231
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18762
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | src/lib/imd.c | 2 | ||||
| -rw-r--r-- | src/lib/jpeg.c | 1 | ||||
| -rw-r--r-- | src/lib/prog_loaders.c | 1 | ||||
| -rw-r--r-- | src/lib/ramtest.c | 3 |
4 files changed, 2 insertions, 5 deletions
diff --git a/src/lib/imd.c b/src/lib/imd.c index e3a3927500..8f65fa8285 100644 --- a/src/lib/imd.c +++ b/src/lib/imd.c @@ -439,7 +439,7 @@ int imd_create_tiered_empty(struct imd *imd, size_t lg_root_size, size_t lg_entry_align, size_t sm_root_size, size_t sm_entry_align) { - size_t sm_region_size;; + size_t sm_region_size; const struct imd_entry *e; struct imdr *imdr; diff --git a/src/lib/jpeg.c b/src/lib/jpeg.c index 06c9d7c6cf..f06d490329 100644 --- a/src/lib/jpeg.c +++ b/src/lib/jpeg.c @@ -417,7 +417,6 @@ int jpeg_decode(unsigned char *buf, unsigned char *pic, break; default: return ERR_DEPTH_MISMATCH; - break; } } } diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c index 58c1a8a7e0..128869b2ba 100644 --- a/src/lib/prog_loaders.c +++ b/src/lib/prog_loaders.c @@ -166,7 +166,6 @@ static struct prog global_payload = void __attribute__((weak)) mirror_payload(struct prog *payload) { - return; } void payload_load(void) diff --git a/src/lib/ramtest.c b/src/lib/ramtest.c index 806e7d75a5..419d0eb75f 100644 --- a/src/lib/ramtest.c +++ b/src/lib/ramtest.c @@ -120,9 +120,8 @@ static int ram_bitset_nodie(unsigned long start) post_code(0xea); printk(BIOS_DEBUG, "\nDRAM did _NOT_ verify!\n"); return 1; - } else { - printk(BIOS_DEBUG, "\nDRAM range verified.\n"); } + printk(BIOS_DEBUG, "\nDRAM range verified.\n"); return 0; } |