diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2019-08-08 11:21:51 -0600 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-08-21 09:34:17 +0000 |
| commit | 44348185d97036012353c8d53211c68c2444b36d (patch) | |
| tree | 4186a74b1312bcc7429cd45b89205d7121448b30 | |
| parent | 220ac049ba3898911a7af990df82b56768a47aaf (diff) | |
| download | coreboot-44348185d97036012353c8d53211c68c2444b36d.tar.xz | |
soc/intel/common/smm: Add missing printk statement
SMI trap handler was missing a printk statement, which caused
Coverity to flag "data &= mask;" as a redundant operation.
Change-Id: I71da74e5e08e7d7e6d61c1925db19324efd73f0a
Found-by: Coverity CID 1381621
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34797
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
| -rw-r--r-- | src/soc/intel/common/block/smm/smitraphandler.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/soc/intel/common/block/smm/smitraphandler.c b/src/soc/intel/common/block/smm/smitraphandler.c index bfa984651e..974c4897a8 100644 --- a/src/soc/intel/common/block/smm/smitraphandler.c +++ b/src/soc/intel/common/block/smm/smitraphandler.c @@ -108,6 +108,7 @@ void smihandler_southbridge_monitor( /* Trapped write data */ data = pcr_read32(PID_PSTH, PCR_PSTH_TRPD); data &= mask; + printk(BIOS_DEBUG, " iotrap read data = 0x%08x\n", data); } } |