diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-03-25 22:45:18 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-04-03 06:18:36 +0200 |
| commit | 4a6e00fd365bee06e2860f813c0fc05c5f4c22b9 (patch) | |
| tree | 38b75eb4499b8f1bb04450cb7a946f4dc6401369 | |
| parent | 1498efe2d04f13f42bd7c080b7b1c3027a34646b (diff) | |
| download | coreboot-4a6e00fd365bee06e2860f813c0fc05c5f4c22b9.tar.xz | |
AGESA: Move EmptyHeap() call
Specification says to do CAR teardown as part of AmdInitPost().
Move initializing the final AGESA heap storage to AmdInitEnv()
so the buffer is not invalidated without writeback.
Change-Id: I3a5d497d0e25ec291f722e9f089bc8928238c3f9
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/19024
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
| -rw-r--r-- | src/northbridge/amd/agesa/agesawrapper.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/northbridge/amd/agesa/agesawrapper.c b/src/northbridge/amd/agesa/agesawrapper.c index 0a6f2a3370..d21c9c371a 100644 --- a/src/northbridge/amd/agesa/agesawrapper.c +++ b/src/northbridge/amd/agesa/agesawrapper.c @@ -111,9 +111,6 @@ AGESA_STATUS agesawrapper_amdinitpost(void) AmdReleaseStruct(&AmdParamStruct); - /* Initialize heap space */ - EmptyHeap(); - return status; } @@ -153,6 +150,9 @@ AGESA_STATUS agesawrapper_amdinitenv(void) AMD_INTERFACE_PARAMS AmdParamStruct; AMD_ENV_PARAMS *EnvParam; + /* Initialize heap space */ + EmptyHeap(); + memset(&AmdParamStruct, 0, sizeof(AMD_INTERFACE_PARAMS)); AmdParamStruct.AgesaFunctionName = AMD_INIT_ENV; |