diff options
| author | Andrey Petrov <andrey.petrov@intel.com> | 2016-04-15 21:32:30 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2016-05-18 07:04:36 +0200 |
| commit | 5ede3d8ccebde6f26c6b24f6458e57d99d5f3957 (patch) | |
| tree | 0a1645c3b367da9e776fa6e16429fe68fc74ba8b | |
| parent | 9be1a115f141ce29ef9527b4bf954189c336546a (diff) | |
| download | coreboot-5ede3d8ccebde6f26c6b24f6458e57d99d5f3957.tar.xz | |
soc/intel/apollolake: Do not use StackBase FSP-M parameter
Currently, StackBase field doesn't work and changing it from default
value leads to crash.
Change-Id: Id3f3ea9a834d0c04a8381938535109d6a729cca2
Signed-off-by: Andrey Petrov <andrey.petrov@intel.com>
Reviewed-on: https://review.coreboot.org/14803
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | src/soc/intel/apollolake/romstage.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index 8ec94a7cb3..da537996dc 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -238,9 +238,13 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd) * requests. * TODO: add checks to avoid overlap/conflict of CAR usage. */ + + /* fsp does not work with StackBase modified, so use default */ +#if 0 + /* FIXME: remove this once FSP is fixed */ mupd->FspmArchUpd.StackBase = _car_region_end - mupd->FspmArchUpd.StackSize; - +#endif arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION; if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) { |