diff options
| author | Nico Huber <nico.huber@secunet.com> | 2014-07-04 18:17:39 +0200 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2014-07-10 20:55:36 +0200 |
| commit | 6a058904d9fc55975689981cad3d65e84e0501d7 (patch) | |
| tree | c06cc3bc9c45028f6d11ac9c59aff11d4ed07953 | |
| parent | fd570665ce9eb76e02d1fe5fb958e87ea017fd73 (diff) | |
| download | coreboot-6a058904d9fc55975689981cad3d65e84e0501d7.tar.xz | |
libpayload: Remove redundant phys_to_virt() from xHCI driver
Remove a redundant phys_to_virt() that sneaked in the initialization of
PCI xHCI controllers. The use of casts from void* to u32 (and vice versa)
prompts for things going wrong here. That will be addressed in a later
commit.
Change-Id: Ibc71ed6ee7016529c0e3a51559aaec07aaaba315
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: http://review.coreboot.org/6243
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
| -rw-r--r-- | payloads/libpayload/drivers/usb/xhci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/payloads/libpayload/drivers/usb/xhci.c b/payloads/libpayload/drivers/usb/xhci.c index 6106342e58..d9ac0a490b 100644 --- a/payloads/libpayload/drivers/usb/xhci.c +++ b/payloads/libpayload/drivers/usb/xhci.c @@ -305,7 +305,7 @@ xhci_pci_init (pcidev_t addr) u32 reg_addr; hci_t *controller; - reg_addr = (u32)phys_to_virt(pci_read_config32 (addr, 0x10) & ~0xf); + reg_addr = pci_read_config32 (addr, 0x10) & ~0xf; if (pci_read_config32 (addr, 0x14) > 0) { fatal("We don't do 64bit addressing.\n"); } |