diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2006-12-01 13:14:55 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2006-12-01 13:14:55 +0000 |
| commit | 6b2475dd8198f3f6b43b96d48b2f4e3de75042a4 (patch) | |
| tree | 88529543343e01ad434299a60a563cfbe08954c8 | |
| parent | 39b13f4fa0b17b496ded754b875213b72d951129 (diff) | |
| download | coreboot-6b2475dd8198f3f6b43b96d48b2f4e3de75042a4.tar.xz | |
Explicitly set the CLKIN to 24 MHz on all ITE Super I/Os, otherwise
serial output might not always work correctly (trivial).
Thanks Philipp Degler <pdegler@rumms.uni-mannheim.de> for testing and
reporting this issue.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2513 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
| -rw-r--r-- | src/superio/ite/it8673f/it8673f_early_serial.c | 2 | ||||
| -rw-r--r-- | src/superio/ite/it8705f/it8705f_early_serial.c | 4 | ||||
| -rw-r--r-- | src/superio/ite/it8712f/it8712f_early_serial.c | 4 | ||||
| -rw-r--r-- | src/superio/ite/it8716f/it8716f_early_serial.c | 4 | ||||
| -rw-r--r-- | src/superio/ite/it8718f/it8718f_early_serial.c | 4 |
5 files changed, 9 insertions, 9 deletions
diff --git a/src/superio/ite/it8673f/it8673f_early_serial.c b/src/superio/ite/it8673f/it8673f_early_serial.c index b47d36f5e8..0bb8f05182 100644 --- a/src/superio/ite/it8673f/it8673f_early_serial.c +++ b/src/superio/ite/it8673f/it8673f_early_serial.c @@ -86,7 +86,7 @@ static void it8673f_enable_serial(device_t dev, unsigned iobase) it8673f_sio_write(IT8673F_KBCK, 0x30, 0x1); /* Keyboard */ it8673f_sio_write(IT8673F_KBCM, 0x30, 0x1); /* Mouse */ - /* Select 24MHz CLKIN (clear bit 0). TODO: is this really needed? */ + /* Select 24MHz CLKIN (clear bit 0). */ it8673f_sio_write(0x00, IT8673F_CONFIG_REG_CLOCKSEL, 0x00); /* Clear software suspend mode (clear bit 0). */ diff --git a/src/superio/ite/it8705f/it8705f_early_serial.c b/src/superio/ite/it8705f/it8705f_early_serial.c index 7b5c97e247..54ff45bd11 100644 --- a/src/superio/ite/it8705f/it8705f_early_serial.c +++ b/src/superio/ite/it8705f/it8705f_early_serial.c @@ -78,8 +78,8 @@ static void it8705f_enable_serial(device_t dev, unsigned iobase) it8705f_sio_write(IT8705F_IR, 0x30, 0x1); /* Consumer IR */ it8705f_sio_write(IT8705F_MIDI, 0x30, 0x1); /* MIDI port */ - /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */ - /* it8705f_sio_write(0x00, IT8705F_CONFIG_REG_CLOCKSEL, 0x01); */ + /* Select 24MHz CLKIN (set bit 0). */ + it8705f_sio_write(0x00, IT8705F_CONFIG_REG_CLOCKSEL, 0x01); /* Clear software suspend mode (clear bit 0). TODO: Needed? */ /* it8705f_sio_write(0x00, IT8705F_CONFIG_REG_SWSUSP, 0x00); */ diff --git a/src/superio/ite/it8712f/it8712f_early_serial.c b/src/superio/ite/it8712f/it8712f_early_serial.c index 3d6c2e8f6a..932fcb2fe3 100644 --- a/src/superio/ite/it8712f/it8712f_early_serial.c +++ b/src/superio/ite/it8712f/it8712f_early_serial.c @@ -78,8 +78,8 @@ static void it8712f_enable_serial(device_t dev, unsigned iobase) it8712f_sio_write(IT8712F_GAME, 0x30, 0x1); /* GAME port */ it8712f_sio_write(IT8712F_IR, 0x30, 0x1); /* Consumer IR */ - /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */ - /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */ + /* Select 24MHz CLKIN (set bit 0). */ + it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); /* Clear software suspend mode (clear bit 0). TODO: Needed? */ /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */ diff --git a/src/superio/ite/it8716f/it8716f_early_serial.c b/src/superio/ite/it8716f/it8716f_early_serial.c index 7c451b7a49..49df986e19 100644 --- a/src/superio/ite/it8716f/it8716f_early_serial.c +++ b/src/superio/ite/it8716f/it8716f_early_serial.c @@ -78,8 +78,8 @@ static void it8716f_enable_serial(device_t dev, unsigned iobase) it8716f_sio_write(IT8716F_GAME, 0x30, 0x1); /* GAME port */ it8716f_sio_write(IT8716F_IR, 0x30, 0x1); /* Consumer IR */ - /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */ - /* it8716f_sio_write(0x00, IT8716F_CONFIG_REG_CLOCKSEL, 0x01); */ + /* Select 24MHz CLKIN (set bit 0). */ + it8716f_sio_write(0x00, IT8716F_CONFIG_REG_CLOCKSEL, 0x01); /* Clear software suspend mode (clear bit 0). TODO: Needed? */ /* it8716f_sio_write(0x00, IT8716F_CONFIG_REG_SWSUSP, 0x00); */ diff --git a/src/superio/ite/it8718f/it8718f_early_serial.c b/src/superio/ite/it8718f/it8718f_early_serial.c index ed750a042d..d71fbe1991 100644 --- a/src/superio/ite/it8718f/it8718f_early_serial.c +++ b/src/superio/ite/it8718f/it8718f_early_serial.c @@ -76,8 +76,8 @@ static void it8718f_enable_serial(device_t dev, unsigned iobase) it8718f_sio_write(IT8718F_KBCM, 0x30, 0x1); /* Mouse */ it8718f_sio_write(IT8718F_IR, 0x30, 0x1); /* Consumer IR */ - /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */ - /* it8718f_sio_write(0x00, IT8718F_CONFIG_REG_CLOCKSEL, 0x01); */ + /* Select 24MHz CLKIN (set bit 0). */ + it8718f_sio_write(0x00, IT8718F_CONFIG_REG_CLOCKSEL, 0x01); /* Clear software suspend mode (clear bit 0). TODO: Needed? */ /* it8718f_sio_write(0x00, IT8718F_CONFIG_REG_SWSUSP, 0x00); */ |