diff options
| author | Richard Spiegel <richard.spiegel@silverbackltd.com> | 2017-11-10 08:33:57 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2017-11-10 19:11:38 +0000 |
| commit | 77fee09509807f17d2d8a638b3e72cacb5bcdbc4 (patch) | |
| tree | 845e6cfee8b6540eacbdc54400f4b226c22b8d65 | |
| parent | cd04e31c8beaecb2e4c95ab47934b32b2b5e3b06 (diff) | |
| download | coreboot-77fee09509807f17d2d8a638b3e72cacb5bcdbc4.tar.xz | |
soc/amd/stoneyridge: Use uint8_t as type for SPD address
SPD address is currenty int. It should be uint8_t.
BUG=b:62200225
Change-Id: Ia11c5994c41849ba01ecae3cee6fa97c527134d0
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/22300
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
| -rw-r--r-- | src/soc/amd/common/dimmSpd.h | 2 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/dimmSpd.c | 2 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/smbus_spd.c | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/src/soc/amd/common/dimmSpd.h b/src/soc/amd/common/dimmSpd.h index cdcdb731f5..9abdb984d4 100644 --- a/src/soc/amd/common/dimmSpd.h +++ b/src/soc/amd/common/dimmSpd.h @@ -20,7 +20,7 @@ AGESA_STATUS AmdMemoryReadSPD(IN UINT32 Func, IN UINTN Data, IN OUT AGESA_READ_SPD_PARAMS *SpdData); -int sb_readSpd(int spdAddress, char *buf, size_t len); +int sb_readSpd(uint8_t spdAddress, char *buf, size_t len); int smbus_readSpd(int spdAddress, char *buf, size_t len); #endif diff --git a/src/soc/amd/stoneyridge/dimmSpd.c b/src/soc/amd/stoneyridge/dimmSpd.c index 764d10396f..f4507d65f8 100644 --- a/src/soc/amd/stoneyridge/dimmSpd.c +++ b/src/soc/amd/stoneyridge/dimmSpd.c @@ -27,7 +27,7 @@ AGESA_STATUS AmdMemoryReadSPD(UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PARAMS *info) { - int spdAddress; + uint8_t spdAddress; DEVTREE_CONST struct device *dev = dev_find_slot(0, DCT_DEVFN); DEVTREE_CONST struct soc_amd_stoneyridge_config *conf = dev->chip_info; diff --git a/src/soc/amd/stoneyridge/smbus_spd.c b/src/soc/amd/stoneyridge/smbus_spd.c index a2763357f4..0b0876074f 100644 --- a/src/soc/amd/stoneyridge/smbus_spd.c +++ b/src/soc/amd/stoneyridge/smbus_spd.c @@ -30,10 +30,10 @@ * sending offset for every byte. * Reads 128 bytes in 7-8 ms at 400 KHz. */ -static int readspd(uint16_t iobase, int SmbusSlaveAddress, +static int readspd(uint16_t iobase, uint8_t SmbusSlaveAddress, char *buffer, size_t count) { - u8 dev_addr; + uint8_t dev_addr; size_t index; int error; char *pbuf = buffer; @@ -90,7 +90,7 @@ static void setupFch(uint16_t ioBase) outb(SMBSLV_STAT_CLEAR, ioBase + SMBSLVSTAT); } -int sb_readSpd(int spdAddress, char *buf, size_t len) +int sb_readSpd(uint8_t spdAddress, char *buf, size_t len) { uint16_t ioBase = SMB_BASE_ADDR; setupFch(ioBase); |