diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2017-04-06 14:21:31 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-04-25 18:46:04 +0200 |
| commit | 878c2de41b17443c8b358c4a3171669d8aab5ccd (patch) | |
| tree | a9f8cbd117088d4b60da5e8b3fc6306238632a67 | |
| parent | 2873a4aea4d27f49e5dc7014b1153a9985048d29 (diff) | |
| download | coreboot-878c2de41b17443c8b358c4a3171669d8aab5ccd.tar.xz | |
util/ectool: Dump ram by default
According to the comment above the default should dump the EC ram,
though is never reached since the variable 'write_addr' is not 0, but
initialized at -1.
Also removes brackets around one line statement below if to make
checkpatch.pl happy.
Change-Id: I390996b253f2f20682cd9ab2d4f560de6eccfc57
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19152
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Alexander Couzens <lynxis@fe80.eu>
| -rw-r--r-- | util/ectool/ectool.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/util/ectool/ectool.c b/util/ectool/ectool.c index 6d9668ded2..dcf17288f1 100644 --- a/util/ectool/ectool.c +++ b/util/ectool/ectool.c @@ -135,9 +135,8 @@ int main(int argc, char *argv[]) } /* preserve default - dump_ram if nothing selected */ - if (!dump_ram && !dump_idx && !dump_query && !write_addr) { + if (!dump_ram && !dump_idx && !dump_query && (write_addr == -1)) dump_ram = 1; - } if (dump_ram) { printf("EC RAM:\n"); |