diff options
| author | Barnali Sarkar <barnali.sarkar@intel.com> | 2016-08-04 17:46:55 +0530 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-08-08 18:31:38 +0200 |
| commit | a7b97510aeb1652fd0006c9b2d10df6568f37e2e (patch) | |
| tree | 3fc01d947c4ffb108815f43027d176cf7f802b93 | |
| parent | 8f2f22d25806a4547be1a1a125f153bb4b0fe581 (diff) | |
| download | coreboot-a7b97510aeb1652fd0006c9b2d10df6568f37e2e.tar.xz | |
soc/intel/skylake: Clean up SoC ASL code.
List of changes done here in this patch
1. Remove CARD definition from EMMC and SD Card Controller in scs.asl
since _RMV method does not get evaluated while setting up removable
attribute in sysfs in kernel.
"cat /sys/block/mmcblk1/removable" this command always returns 0.
This CARD Device includes _ADR which follows SDIO Bus format. But,
SD/EMMC sits on PCI Bus.
Hence this CARD Device specific _ADR code is also not needed.
2. Remove Base Address for ACPI debug output memory buffer in
systemagent.asl as it is not getting used throughout the code.
BUG=none
BRANCH=none
TEST=Build and boot kunimitsu
Change-Id: I29effaffdafcc21e26445ec3c54aedecdbc50274
Signed-off-by: Barnali Sarkar <barnali.sarkar@intel.com>
Reviewed-on: https://review.coreboot.org/16068
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
| -rw-r--r-- | src/soc/intel/skylake/acpi/scs.asl | 18 | ||||
| -rw-r--r-- | src/soc/intel/skylake/acpi/systemagent.asl | 5 |
2 files changed, 0 insertions, 23 deletions
diff --git a/src/soc/intel/skylake/acpi/scs.asl b/src/soc/intel/skylake/acpi/scs.asl index 45591cb4c6..aea4483473 100644 --- a/src/soc/intel/skylake/acpi/scs.asl +++ b/src/soc/intel/skylake/acpi/scs.asl @@ -59,15 +59,6 @@ Device (EMMC) Store (Local0, ^D0D3) Store (^D0D3, Local0) } - - Device (CARD) - { - Name (_ADR, 0x00000008) - Method (_RMV, 0, NotSerialized) - { - Return (0) - } - } } #if !IS_ENABLED(CONFIG_EXCLUDE_NATIVE_SD_INTERFACE) @@ -130,14 +121,5 @@ Device (SDXC) ^^PCRO (PID_GPIOCOM3, 0x4e4, 0x00001000) ^^PCRO (PID_GPIOCOM3, 0x4f4, 0x00001000) } - - Device (CARD) - { - Name (_ADR, 0x00000008) - Method (_RMV, 0, NotSerialized) - { - Return (1) - } - } } #endif diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl index 842bb701a9..a04fe9eb6a 100644 --- a/src/soc/intel/skylake/acpi/systemagent.asl +++ b/src/soc/intel/skylake/acpi/systemagent.asl @@ -340,11 +340,6 @@ Device (PDRC) /* HPET address decode range */ Memory32Fixed (ReadWrite, HPET_BASE_ADDRESS, 0x400) - - /* Debug Base Address - * Base Address for ACPI debug output memory buffer - */ - Memory32Fixed (ReadWrite, 0, 0, DBAD) }) Method (_CRS, 0, Serialized) |