diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2016-04-07 16:58:10 -0500 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-04-11 16:10:43 +0200 |
| commit | b2229dc1997b22d6497ebc1664b2c710584e8117 (patch) | |
| tree | 6b86dd2212cd68d4a3934a33345901dc2e75eead | |
| parent | edff1655fe4f3dd27645a9acd846576e75e4ad72 (diff) | |
| download | coreboot-b2229dc1997b22d6497ebc1664b2c710584e8117.tar.xz | |
util/crossgcc/buildgcc: correct clang test
On certain versions of /bin/sh the following sequence
causes problems.
'$CC --version | grep clang &>/dev/null && ...'
The above is a bashish for 2>&1 >/dev/null. However, buildgcc
is interpeted by /bin/sh which doesn't necessarily mean bash.
On dash it's effectively forking grep off into the background
and always evaluating an empty statement to /dev/null while
unconditionally running whatever follows the &&.
Change-Id: Ie3a2ebb12226434d50a7b2a7e254c8b80ae4c46b
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/14281
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
| -rwxr-xr-x | util/crossgcc/buildgcc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index e2a30d8981..a3da9c0908 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -455,7 +455,7 @@ build_BINUTILS() { build_GCC() { # Work around crazy code generator in GCC that confuses CLANG. - $CC --version | grep clang &>/dev/null && + $CC --version | grep clang >/dev/null 2>&1 && \ HOSTCFLAGS="$HOSTCFLAGS -fbracket-depth=1024" # GCC does not honor HOSTCFLAGS at all. CFLAGS are used for |