diff options
| author | Furquan Shaikh <furquan@chromium.org> | 2017-06-09 17:57:59 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2017-06-14 20:20:21 +0200 |
| commit | b2f423578ea93bb5f1e56084ba42f4c7b68c130c (patch) | |
| tree | 0554cd69893a9418e96dde0733b05ffedf14827f | |
| parent | 268eea0e4158ab0186710cd8901d42d31df4b19c (diff) | |
| download | coreboot-b2f423578ea93bb5f1e56084ba42f4c7b68c130c.tar.xz | |
mainboard/google/poppy: Disable unused TPM interface dynamically
Based on the config options selected, decide at runtime which TPM
interface should be disabled so that ACPI tables are not generated for
that interface.
TEST=Verified that unused interface does not show up in ACPI tables.
Change-Id: Iee8f49e484ed024c549f60c88d874c08873b75cb
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/20141
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
| -rw-r--r-- | src/mainboard/google/poppy/mainboard.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/src/mainboard/google/poppy/mainboard.c b/src/mainboard/google/poppy/mainboard.c index 3ee01467cd..3558ce0c92 100644 --- a/src/mainboard/google/poppy/mainboard.c +++ b/src/mainboard/google/poppy/mainboard.c @@ -17,6 +17,7 @@ #include <baseboard/variants.h> #include <device/device.h> #include <ec/ec.h> +#include <soc/pci_devs.h> #include <soc/nhlt.h> #include <vendorcode/google/chromeos/chromeos.h> @@ -56,9 +57,24 @@ static unsigned long mainboard_write_acpi_tables(device_t device, static void mainboard_enable(device_t dev) { + device_t tpm; + dev->ops->init = mainboard_init; dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; dev->ops->write_acpi_tables = mainboard_write_acpi_tables; + + /* Disable unused interface(s) for TPM. */ + if (!IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM)) { + tpm = PCH_DEV_GSPI0; + if (tpm) + tpm->enabled = 0; + } + + if (!IS_ENABLED(CONFIG_POPPY_USE_I2C_TPM)) { + tpm = PCH_DEV_I2C1; + if (tpm) + tpm->enabled = 0; + } } struct chip_operations mainboard_ops = { |