diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2016-07-05 09:41:59 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2016-07-13 18:35:03 +0200 |
| commit | b6fc727903775b6a100d8cf02cb53ac22fae49d9 (patch) | |
| tree | 4756b6dedb43850b3ee20ea6ad5b8b6fa6d59c58 | |
| parent | 044fb53a2ee9f4e4599d87b48ecd2e309eac4dee (diff) | |
| download | coreboot-b6fc727903775b6a100d8cf02cb53ac22fae49d9.tar.xz | |
FSP1_0 does not support HAVE_ACPI_RESUME
FSP1_0 places romstage ram stack at fixed location of
RAMTOP in low memory before returning to coreboot proper.
There is no possibility of making a complete backup of
RAMBASE..RAMTOP region and currently such backup is not
even attempted.
As a conclusion, S3 resume would always cause OS memory
corruption.
Change-Id: I5b9dd4069082e022b01b0d6a9ad5dec28a06e8b0
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/15576
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | src/mainboard/esd/atom15/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/intel/minnowmax/Kconfig | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/src/mainboard/esd/atom15/Kconfig b/src/mainboard/esd/atom15/Kconfig index 3f4b76ba1b..814177e3e6 100644 --- a/src/mainboard/esd/atom15/Kconfig +++ b/src/mainboard/esd/atom15/Kconfig @@ -23,7 +23,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select TSC_MONOTONIC_TIMER - select HAVE_ACPI_RESUME config MAINBOARD_DIR string diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig index 2f23270ea7..f0c4526f6a 100644 --- a/src/mainboard/intel/minnowmax/Kconfig +++ b/src/mainboard/intel/minnowmax/Kconfig @@ -23,7 +23,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select TSC_MONOTONIC_TIMER - select HAVE_ACPI_RESUME config MAINBOARD_DIR string |