summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRonald G. Minnich <rminnich@gmail.com>2006-05-12 20:05:08 +0000
committerRonald G. Minnich <rminnich@gmail.com>2006-05-12 20:05:08 +0000
commitb9a335cb9b70bc8b0a5ebd099e1f2194ecaeef27 (patch)
tree1203e93d68aa628580973dd148db44687b7f2a90
parent6084160f2de64cf937f4aab37c17f56f579a4d9a (diff)
downloadcoreboot-b9a335cb9b70bc8b0a5ebd099e1f2194ecaeef27.tar.xz
correct it, finally.
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2304 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
-rw-r--r--src/mainboard/olpc/rev_a/auto.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/src/mainboard/olpc/rev_a/auto.c b/src/mainboard/olpc/rev_a/auto.c
index 1e11ec0081..53ac114a63 100644
--- a/src/mainboard/olpc/rev_a/auto.c
+++ b/src/mainboard/olpc/rev_a/auto.c
@@ -81,7 +81,10 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl)
/* get the module bank density, SPD byte 31 */
/* this is multiples of 8 MB */
- val = 128 / 8;
+ /* actually it is 2^x*4, where x is the value you put in */
+ /* for OLPC, set default size */
+ /* dimm size - hardcoded 128Mb */
+ val = 5;
msr.hi &= ~(0xf << CF07_UPPER_D0_SZ_SHIFT);
msr.hi |= (val << CF07_UPPER_D0_SZ_SHIFT);
@@ -94,11 +97,6 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl)
print_debug_hex32(msr.hi);
print_debug("\r\n");
- /* for OLPC, set default size */
- /* dimm size - hardcoded 128Mb */
-// msr.hi &= ~(0xf << CF07_UPPER_D0_SZ_SHIFT);
-// msr.hi |= (5 << CF07_UPPER_D0_SZ_SHIFT);
-
/* this is a standard value, DOES NOT PROBABLY MATCH FROM ABOVE */
/* well, it may be close. It's about 200,000 ticks */
msr.lo = 0x00003000;