summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-11-21 02:22:33 +1100
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-11-21 02:35:59 +0100
commitd994ef193276cd118be9120ab93c6850830a450a (patch)
tree021de440d7e046ad049b83fcebb19f8d8c74157e
parent023ed1f999e9ddc1d317407a73d99699636d2b45 (diff)
downloadcoreboot-d994ef193276cd118be9120ab93c6850830a450a.tar.xz
northbridge/amd/agesa: DEVICE_NOOP some stub functions
Use 'DEVICE_NOOP' over stub functions to reduce loc and improve formalism. Change-Id: I9c8d608539647cce22fb1dfbe284a6043d3d23d9 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/7534 Tested-by: build bot (Jenkins) Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
-rw-r--r--src/northbridge/amd/agesa/family15/northbridge.c6
-rw-r--r--src/northbridge/amd/agesa/family15tn/northbridge.c7
-rw-r--r--src/northbridge/amd/agesa/family16kb/northbridge.c5
3 files changed, 3 insertions, 15 deletions
diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c
index aab061eaf8..c46db7cc92 100644
--- a/src/northbridge/amd/agesa/family15/northbridge.c
+++ b/src/northbridge/amd/agesa/family15/northbridge.c
@@ -472,10 +472,6 @@ static void nb_set_resources(device_t dev)
}
}
-static void northbridge_init(struct device *dev)
-{
-}
-
static unsigned scan_chains(device_t dev, unsigned max)
{
unsigned nodeid;
@@ -503,7 +499,7 @@ static struct device_operations northbridge_operations = {
.read_resources = nb_read_resources,
.set_resources = nb_set_resources,
.enable_resources = pci_dev_enable_resources,
- .init = northbridge_init,
+ .init = DEVICE_NOOP,
.scan_bus = scan_chains,
.enable = 0,
.ops_pci = 0,
diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c
index 2632321093..474767e029 100644
--- a/src/northbridge/amd/agesa/family15tn/northbridge.c
+++ b/src/northbridge/amd/agesa/family15tn/northbridge.c
@@ -463,16 +463,11 @@ static void nb_set_resources(device_t dev)
}
}
-static void northbridge_init(struct device *dev)
-{
-}
-
-
static struct device_operations northbridge_operations = {
.read_resources = nb_read_resources,
.set_resources = nb_set_resources,
.enable_resources = pci_dev_enable_resources,
- .init = northbridge_init,
+ .init = DEVICE_NOOP,
.enable = 0,
.ops_pci = 0,
};
diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c
index d47a00d23d..74a72f4d36 100644
--- a/src/northbridge/amd/agesa/family16kb/northbridge.c
+++ b/src/northbridge/amd/agesa/family16kb/northbridge.c
@@ -444,9 +444,6 @@ static void set_resources(device_t dev)
}
}
-static void northbridge_init(struct device *dev)
-{
-}
#if 0 /* TODO: Check if needed. */
static unsigned scan_chains(device_t dev, unsigned max)
{
@@ -475,7 +472,7 @@ static struct device_operations northbridge_operations = {
.read_resources = read_resources,
.set_resources = set_resources,
.enable_resources = pci_dev_enable_resources,
- .init = northbridge_init,
+ .init = DEVICE_NOOP,
//.scan_bus = scan_chains, /* TODO: */
.enable = 0,
.ops_pci = 0,