diff options
| author | Daniel Kang <daniel.h.kang@intel.com> | 2020-06-03 14:02:25 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-06-22 12:00:14 +0000 |
| commit | eb43ca5fb14addd98b52d4dd8040b65f161edb78 (patch) | |
| tree | c8c75a4ff3c8ac33f59cc27859197f02847104de | |
| parent | 51f0129ffd9191356167056f56c690082bebabf2 (diff) | |
| download | coreboot-eb43ca5fb14addd98b52d4dd8040b65f161edb78.tar.xz | |
mb/google/volteer: Change VCM and EEPROM configs for ov8856
TGL RVP and Volteer use ov8856 camera module from different vendors.
TGL RVP from Foxlink and Volteer from Sunny. ov8856 sensor is identical
for the two modules but VCM and EEPROM are different. Originally,
Volteer ACPI was set to align with Sunny module, GT9679. But it turned
out GT9679 is compatible with Foxlink's DW9768. So Volteer camera ACPI
configuration doesn't need to keep GT9679.
BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.
Signed-off-by: Daniel Kang <daniel.h.kang@intel.com>
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42048
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Daniel H Kang <daniel.h.kang@intel.corp-partner.google.com>
Reviewed-by: Wonkyu Kim <wonkyu.kim@intel.com>
| -rw-r--r-- | src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index 777ab7aa74..a57566262e 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -331,8 +331,8 @@ Scope (\_SB.PCI0.I2C3) Device (VCM0) { Name (_HID, "PRP0001") /* _HID: Hardware ID */ - Name (_UID, 0x03) /* _UID: Unique ID */ - Name (_DDN, "GT9769 VCM") /* _DDN: DOS Device Name */ + Name (_UID, 0x00) /* _UID: Unique ID */ + Name (_DDN, "DW9768 VCM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { Return (0x0F) @@ -364,7 +364,7 @@ Scope (\_SB.PCI0.I2C3) Package (0x02) { "compatible", - "giantec,gt9769-vcm" + "dongwoon,dw9768" } } }) @@ -372,8 +372,8 @@ Scope (\_SB.PCI0.I2C3) Device (NVM0) { Name (_HID, "PRP0001") // _HID: Hardware ID - Name (_UID, 0x03) // _UID: Unique ID - Name (_DDN, "GT9769 EEPROM") // _DDN: DOS Device Name + Name (_UID, 0x01) // _UID: Unique ID + Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) @@ -425,7 +425,7 @@ Scope (\_SB.PCI0.I2C3) Package (0x02) { "compatible", - "giantec,gt9769-eeprom" + "atmel,24c1024" } } }) |