diff options
| author | Martin Roth <martinroth@google.com> | 2015-12-01 10:46:33 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-12-06 18:49:26 +0100 |
| commit | eca844b9490d840377e2d0c54dffc1271758a62b (patch) | |
| tree | 5ec82057b2988d352878704fd6b08c9ff2f0282f | |
| parent | 49fdf3f957869dab82b46d6548f73ceab909132b (diff) | |
| download | coreboot-eca844b9490d840377e2d0c54dffc1271758a62b.tar.xz | |
pcengines/apu1: Supply _HID object for ACPI GPIO devices
The _HID was present for the top level BTNS and LEDS Devices, but
was missing in the individual devices.
The alternative would be to supply the GPIO being used as an _ADR
object, but since it looks like the driver already has another
method of handling that, it isn't required.
Fixes these IASL warnings:
dsdt.aml 1522: Device (BTN1)
Warning 3141 - ^ Missing dependency
(Device object requires a _HID or _ADR in same scope)
dsdt.aml 1567: Device (LED1)
Warning 3141 - ^ Missing dependency
(Device object requires a _HID or _ADR in same scope)
dsdt.aml 1576: Device (LED2)
Warning 3141 - ^ Missing dependency
(Device object requires a _HID or _ADR in same scope)
dsdt.aml 1587: Device (LED3)
Warning 3141 - ^ Missing dependency
(Device object requires a _HID or _ADR in same scope)
Change-Id: I67c48084a6ee2a104ffff2b5a986d24a51ee49e1
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12582
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/mainboard/pcengines/apu1/Kconfig | 4 | ||||
| -rw-r--r-- | src/mainboard/pcengines/apu1/acpi/buttons.asl | 1 | ||||
| -rw-r--r-- | src/mainboard/pcengines/apu1/acpi/leds.asl | 3 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index 0754596ad9..23287762e9 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -110,8 +110,4 @@ config PINMUX_UART_D endchoice -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_PCENGINES_APU1 diff --git a/src/mainboard/pcengines/apu1/acpi/buttons.asl b/src/mainboard/pcengines/apu1/acpi/buttons.asl index 17b2d9aeea..a2120a98e2 100644 --- a/src/mainboard/pcengines/apu1/acpi/buttons.asl +++ b/src/mainboard/pcengines/apu1/acpi/buttons.asl @@ -37,6 +37,7 @@ Scope (\_SB.PCI0.SBUS) Device (BTN1) { + Name (_HID, "PRP0001") Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { diff --git a/src/mainboard/pcengines/apu1/acpi/leds.asl b/src/mainboard/pcengines/apu1/acpi/leds.asl index 91b4d20b1e..1e447f1eb5 100644 --- a/src/mainboard/pcengines/apu1/acpi/leds.asl +++ b/src/mainboard/pcengines/apu1/acpi/leds.asl @@ -35,6 +35,7 @@ Scope (\_SB.PCI0.SBUS) Device (LED1) { + Name (_HID, "PRP0001") Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { @@ -51,6 +52,7 @@ Scope (\_SB.PCI0.SBUS) Device (LED2) { + Name (_HID, "PRP0001") Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { @@ -63,6 +65,7 @@ Scope (\_SB.PCI0.SBUS) Device (LED3) { + Name (_HID, "PRP0001") Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { |